Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the reference to the Verilator model patch up script. #315

Merged

Conversation

jeremybennett
Copy link
Contributor

* core-v-mcu.core: Update the directory with the vedit.sh script.

	* core-v-mcu.core: Update the directory with the vedit.sh script.

Signed-off-by: Jeremy Bennett <jeremy.bennett@embecosm.com>
@jeremybennett
Copy link
Contributor Author

This is a trivial mistake that's been lying around for months. I only missed it because I was using a legacy build directory which happened to have an old version in the correct place.

1 similar comment
@jeremybennett
Copy link
Contributor Author

This is a trivial mistake that's been lying around for months. I only missed it because I was using a legacy build directory which happened to have an old version in the correct place.

@MikeOpenHWGroup
Copy link
Member

This looks like a good fix @jeremybennett, thanks. I see that pre_build_scripts is defined in two places: filesets:pre_build_scripts: and scripts:pre_build_scripts:. Just to I can reproduce the failure and fix, what command-line did you use?

Copy link
Contributor

@gmartin102 gmartin102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@jeremybennett
Copy link
Contributor Author

This looks like a good fix @jeremybennett, thanks. I see that pre_build_scripts is defined in two places: filesets:pre_build_scripts: and scripts:pre_build_scripts:. Just to I can reproduce the failure and fix, what command-line did you use?

I used make model-lib with Verilator 4.203

@MikeOpenHWGroup
Copy link
Member

Hmmm. Something is not right. When I perform a fresh clone of this repo, the make model-lib command works as expected using Verilator 4.226. My commands:

$ git clone git@github.com:openhwgroup/core-v-mcu.git master
$ cd master
$ make model-lib

If I make the change in this PR to my local copy of core-v-mcu.core, the compile fails as follows:

INFO: Running pre_build script pre_build_scripts
sh: 0: cannot open src/openhwgroup.org_systems_core-v-mcu_0/rtl/core-v-mcu/scripts/vedit.sh: No such file
ERROR: Failed to build openhwgroup.org:systems:core-v-mcu:0 : pre_build script 'pre_build_scripts': ['sh', 'src/openhwgroup.org_systems_core-v-mcu_0/rtl/core-v-mcu/scripts/vedit.sh', 'openhwgroup.org_systems_core-v-mcu_0.vc'] exited with error code 2

I doubt (hope?) that the differences between Verilator v4.203 and v4.226 would not explain the differences...

@MikeOpenHWGroup MikeOpenHWGroup merged commit 0beffbd into openhwgroup:master Aug 30, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants