Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable additional chart types for oh-data-series #2946

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

Nadahar
Copy link
Contributor

@Nadahar Nadahar commented Dec 24, 2024

This enables the use of all imported ECharts in (custom) widgets using oh-data-series.

@Nadahar Nadahar force-pushed the enable_additional_echarts_widgets branch from 27f914c to a7f7bf3 Compare December 24, 2024 15:50
@Nadahar Nadahar force-pushed the enable_additional_echarts_widgets branch from a7f7bf3 to f42a58a Compare December 28, 2024 17:19
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

We can apply the exception from DCO here as this is a one liner code-wise and the docs are autogenerated.

Copy link

relativeci bot commented Dec 28, 2024

#2613 Bundle Size — 10.97MiB (~+0.01%).

f42a58a(current) vs 512ecce main#2612(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes
                 Current
#2613
     Baseline
#2612
No change  Initial JS 1.9MiB 1.9MiB
No change  Initial CSS 577.39KiB 577.39KiB
Change  Cache Invalidation 17.59% 17.31%
No change  Chunks 227 227
No change  Assets 250 250
No change  Modules 2949 2949
No change  Duplicate Modules 154 154
Change  Duplicate Code 1.79%(+0.56%) 1.78%
No change  Packages 98 98
No change  Duplicate Packages 2 2
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#2613
     Baseline
#2612
Regression  JS 9.18MiB (~+0.01%) 9.18MiB
No change  CSS 866.47KiB 866.47KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 140.74KiB 140.74KiB
No change  HTML 1.38KiB 1.38KiB
No change  Other 871B 871B

Bundle analysis reportBranch Nadahar:enable_additional_echart...Project dashboard


Generated by RelativeCIDocumentationReport issue

@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Dec 31, 2024
@florian-h05 florian-h05 added this to the 5.0 milestone Dec 31, 2024
@florian-h05 florian-h05 changed the title Enable additional ECharts for oh-data-series Enable additional chart types for oh-data-series Dec 31, 2024
@florian-h05 florian-h05 merged commit 0706f3a into openhab:main Dec 31, 2024
6 checks passed
@Nadahar Nadahar deleted the enable_additional_echarts_widgets branch January 1, 2025 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants