Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MainUI] Add dialog to inbox that shows thing file template #2920

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

seime
Copy link
Contributor

@seime seime commented Dec 14, 2024

Makes it easier for everyone using file configuration to adopt discovered inbox things.

Signed-off-by: Arne Seime <arne.seime@gmail.com>
Copy link

relativeci bot commented Dec 14, 2024

#2564 Bundle Size — 10.9MiB (+0.02%).

e681bd0(current) vs c2ae0ab main#2562(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#2564
     Baseline
#2562
No change  Initial JS 1.92MiB 1.92MiB
Regression  Initial CSS 577.87KiB(~+0.01%) 577.83KiB
Change  Cache Invalidation 23.7% 17.65%
No change  Chunks 226 226
No change  Assets 249 249
No change  Modules 2947 2947
No change  Duplicate Modules 152 152
No change  Duplicate Code 1.8% 1.8%
No change  Packages 96 96
No change  Duplicate Packages 2 2
Bundle size by type  Change 2 changes Regression 2 regressions
                 Current
#2564
     Baseline
#2562
Regression  JS 9.11MiB (+0.02%) 9.11MiB
Regression  CSS 866.78KiB (~+0.01%) 866.74KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 140.74KiB 140.74KiB
No change  HTML 1.38KiB 1.38KiB
No change  Other 871B 871B

Bundle analysis reportBranch seime:inbox_thing_file_templateProject dashboard


Generated by RelativeCIDocumentationReport issue

Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for the result of openhab/openhab-core#4509 before merging anything here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants