Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit alexa parameter state description options #1621

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

jsetton
Copy link
Contributor

@jsetton jsetton commented Jan 2, 2023

Signed-off-by: jsetton <jeremy.setton@gmail.com>
@jsetton jsetton requested a review from a team as a code owner January 2, 2023 08:01
@relativeci
Copy link

relativeci bot commented Jan 2, 2023

Job #672: Bundle Size — 15.96MiB (~-0.01%).

427f39d(current) vs 30ba6be main#671(baseline)

Metrics (1 change)
                 Current
Job #672
     Baseline
Job #671
Initial JS 1.73MiB 1.73MiB
Initial CSS 608.52KiB 608.52KiB
Cache Invalidation 90.48% 90.47%
Chunks 218 218
Assets 688 688
Modules 2007 2007
Duplicate Modules 108 108
Duplicate Code 1.8% 1.8%
Packages 133 133
Duplicate Packages 15 15
Total size by type (2 changes)
                 Current
Job #672
     Baseline
Job #671
CSS 856.56KiB 856.56KiB
Fonts 1.08MiB 1.08MiB
HTML 1.23KiB 1.23KiB
IMG 140.74KiB 140.74KiB
JS 9.03MiB (~+0.01%) 9.03MiB
Media 295.6KiB 295.6KiB
Other 4.59MiB (~-0.01%) 4.59MiB

View job #672 reportView main branch activity

Copy link
Member

@ghys ghys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read through openhab/openhab-alexa#540 and think I understood the problem.

Hope you know what you're doing, 150 seems like a pretty future-proof yet arbitrary limit ;)

@ghys ghys merged commit d915c8a into openhab:main Jan 5, 2023
@ghys ghys added bug Something isn't working enhancement New feature or request main ui Main UI labels Jan 5, 2023
@ghys ghys added this to the 4.0 milestone Jan 5, 2023
@jsetton
Copy link
Contributor Author

jsetton commented Jan 5, 2023

Hope you know what you're doing, 150 seems like a pretty future-proof yet arbitrary limit ;)

Per my testing 150 standard sized options produce a compressed endpoint cookie of ~4KB leaving room for additional capabilities in the case of a group endpoint. I initially was considering a 100 limit but I figure the likelihood of having two capabilities with 100+ options under the same group endpoint is highly unlikely. So I went with a higher limit.

@jsetton jsetton deleted the alexa-param-options-limit branch January 5, 2023 03:35
crnjan pushed a commit to crnjan/openhab-webui that referenced this pull request Jan 17, 2023
Signed-off-by: jsetton <jeremy.setton@gmail.com>
Signed-off-by: Boris Krivonog <boris.krivonog@inova.si>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants