[basicui] Fix setpoint/slider widgets when %unit% is used in state

[lolodomo]

pattern

In OH3.4, getUnitForWidget(Widget w) now returns null when the state pattern contains "%unit%". In that case, the unit must be searched in the item state.

Fix #1605

Signed-off-by: Laurent Garnier lg.hc@free.fr

[lolodomo]

This is a fix on branch 3.4.x to be included in the next 3.4 patch.
The build is working on my machine but failed in Github probably because something is not yet correctly setup:

[ERROR] Failed to execute goal on project org.openhab.ui.reactor.bundles: Could not resolve dependencies for project org.openhab.ui.bundles:org.openhab.ui.reactor.bundles:pom:3.4.1-SNAPSHOT: The following artifacts could not be resolved: org.openhab.core.bom:org.openhab.core.bom.compile:pom:3.4.1-SNAPSHOT, org.openhab.core.bom:org.openhab.core.bom.compile-model:pom:3.4.1-SNAPSHOT: org.openhab.core.bom:org.openhab.core.bom.compile:pom:3.4.1-SNAPSHOT was not found in https://openhab.jfrog.io/openhab/libs-snapshot during a previous attempt. This failure was cached in the local repository and resolution is not reattempted until the update interval of openhab-snapshot has elapsed or updates are forced 

It has been tested successfully on my production environment with the following items:

Number:Temperature DemoTemperature "Temperature [%.2f %unit%]"
Number:Temperature DemoTemperature2 "Temperature 2 [%.2f °C]"
Number:Temperature DemoTemperature3 "Temperature 3"
Number:Temperature DemoTemperature4 "Temperature 4 [%.2f]"
Number DemoTemperature5 "Temperature 5 [%.2f °C]"
Number DemoTemperature6 "Temperature 6"
Number DemoTemperature7 "Temperature 7 [%.2f]"

and the following sitemap:

sitemap demo label="Demo Sitemap" {
        Frame label="Demo Text Items" {
                Text item=DemoTemperature
                Text item=DemoTemperature2
                Text item=DemoTemperature3
                Text item=DemoTemperature4
                Text item=DemoTemperature5
                Text item=DemoTemperature6
                Text item=DemoTemperature7
        }
        Frame label="Demo Slider Items" {
                Slider item=DemoTemperature
                Slider item=DemoTemperature2
                Slider item=DemoTemperature3
                Slider item=DemoTemperature4
                Slider item=DemoTemperature5
                Slider item=DemoTemperature6
                Slider item=DemoTemperature7
        }
        Frame label="Demo Setpoint Items" {
                Setpoint item=DemoTemperature
                Setpoint item=DemoTemperature2
                Setpoint item=DemoTemperature3
                Setpoint item=DemoTemperature4
                Setpoint item=DemoTemperature5
                Setpoint item=DemoTemperature6
                Setpoint item=DemoTemperature7
        }
}

Can someone check what is wrong with the build ? Maybe @wborn or @ghys ?

[lolodomo]

Here is a jar for testing the fix (first rename the extension from zip to jar):
org.openhab.ui.basic-3.4.1-SNAPSHOT.zip

Use bundle:update to update your org.openhab.ui.basic bundle with this jar.

[goligo]

jar testet on my installation - does work for items without state description/pattern as well as items with pattern containing %unit%.

[kaikreuzer]

@lolodomo Please create the PR against the main branch.

[lolodomo]

@lolodomo Please create the PR against the main branch.

Done, it is #1612