-
-
Notifications
You must be signed in to change notification settings - Fork 690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Windows download links and files to delete during manual upgrade #725
Fix Windows download links and files to delete during manual upgrade #725
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi and thanks!
Just one small comment.
@@ -37,7 +37,7 @@ On this page, we will be using `C:\openHAB2` as an example. | |||
The openHAB runtime is distributed using a platform-independent zip file. | |||
To install it, follow these simple steps: | |||
|
|||
1. Choose between the Stable Version [![Download](https://api.bintray.com/packages/openhab/mvn/openhab-distro/images/download.svg)](https://bintray.com/openhab/mvn/download_file?file_path=org%2Fopenhab%2Fdistro%2Fopenhab%2F2.2.0%2Fopenhab-2.2.0.zip) or the latest Snapshot Version [![Download](https://api.bintray.com/packages/openhab/mvn/openhab-distro/images/download.svg?version=2.3.0)](https://openhab.ci.cloudbees.com/job/openHAB-Distribution/lastSuccessfulBuild/artifact/distributions/openhab/target/openhab-2.3.0-SNAPSHOT.zip) of openHAB. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would remove the cloudbees links completely and point to https://www.openhab.org/download/
instead.
That is what i wanted to do anyway for all installation articles in the future.
See #711 for reference.
It simply doesn't make sense for me, to fix those links after every release on every article.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking about that solution as well. I'll remove them!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have also directly opened openhab/website#78 too get this a bit smoother in the future, if possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent! That would indeed make it a bit easier and less confusing. 😄
Signed-off-by: Wouter Born <eclipse@maindrain.net>
7ec52dc
to
35fe870
Compare
…te during manual upgrade (#725) Signed-off-by: Wouter Born <eclipse@maindrain.net>
The Windows instructions are incomplete regarding the files to delete during a manual upgrade (see community topic). This results in an installation that won't start.