-
-
Notifications
You must be signed in to change notification settings - Fork 700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[documentation] Explain implicit profiles #2141
Conversation
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@lolodomo for info.. |
✅ Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits).
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good addition to the docs here. See my small recommendation.
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
There is another page where profiles are defined and this page is not clear about defaults. Edit: it is in fact in the same page ! So maybe you could also fix a little the "Profile" section in this page ? |
@lolodomo my new 'Implicit Profiles' chapter is a direct sub chapter of the 'Profiles' chapter so I am not clear on what extra you want me to add? |
Sorry, I did not realize that. @stefan-hoehn : feel free to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Andrew, for the contribution.
Looks good to me as well.
This PR adds an explanation of how the framework uses implicit profiles for items where no profile is explicitly defined.
See openhab/openhab-addons#15656 (comment)
Signed-off-by: Andrew Fiddian-Green software@whitebear.ch