Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alpine image: Install NodeJS for Matter binding #454

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Alpine image: Install NodeJS for Matter binding #454

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d465fe1
Alpine image: Install NodeJS for Matter binding
florian-h05 Jan 4, 2025
61b961d
Only install NodeJS for openHAB 5 SNAPSHOTs
florian-h05 Jan 7, 2025
7c9b139
Fix shellcheck
florian-h05 Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions alpine/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,8 @@

# Install basepackages. Versions are "pinned" by using a pinned base image.
# hadolint ignore=DL3018
RUN apk update --no-cache && \
RUN version="$(echo "$OPENHAB_VERSION" | sed 's/snapshot/SNAPSHOT/g')" && \

Check failure on line 44 in alpine/Dockerfile

View workflow job for this annotation

GitHub Actions / latest-alpine 

SC2143 style: Use grep -q instead of comparing output with [ -n .. ].

Check failure on line 44 in alpine/Dockerfile

View workflow job for this annotation

GitHub Actions / snapshot-alpine 

SC2143 style: Use grep -q instead of comparing output with [ -n .. ].
apk update --no-cache && \
apk add --no-cache \
arping \
bash \
Expand All @@ -56,10 +57,12 @@
su-exec \
tini \
ttf-dejavu \
openjdk${JAVA_VERSION} \
openjdk"${JAVA_VERSION}" \
unzip \
wget \
zip && \
# Install NodeJS only for openHAB 5 SNAPSHOT
if [ $(echo "$version" | grep -E '^5\..+-SNAPSHOT$') ]; then apk add --no-cache nodejs; fi && \
chmod u+s /usr/sbin/arping && \
rm -rf /var/cache/apk/*

Expand Down
Loading