-
-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable HTTP/2 for HTTPS #1711
Enable HTTP/2 for HTTPS #1711
Conversation
Signed-off-by: Florian Hotze <dev@florianhotze.com>
Isn't that removing http/1.1 support for secure connections? |
Yes, but I see no harm in doing so: |
I'm ok with that, but I would like to hear the opinion of other @openhab/distro-maintainers and @openhab/architecture-council |
Let's also ask @ghys for his opinion. |
I had to keep http/1 and TLS 1.1 for quite a while longer than I wanted due to Android-based wall displays. But it is more than ten years since Android 4 and time to get rid of those devices anyway - if still in use. So 👍 from my side. |
If really needed, you could use nginx to get http/1 and TLS 1.1 available for them - but given the vulnerabilities of TLS 1.1 you could also consider to use plain HTTP ;-) |
Signed-off-by: Florian Hotze <dev@florianhotze.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Let's wait for more comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this change now that we don’t add them as compile time dependencies on core?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably not. OTOH: You can easily try if you need it. If it comes up and works without, don't add it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tested, it is not needed, the demo app still starts fine.
I have created #1712 to revert this change.
I think there will be much complaining but I also think this is somethjing that probably needs to be done anyway. Never underestimate the willingness of people to keep running stuff far beyond it's end of life. I would request an update to the reverse proxy docs to correspond with this change, assuming end users need to adjust their nginx or apache configs to account for this. |
If one has a browser older than 2015 (where HTTP/2 was added to all major browsers) I wish them good luck to not get some malware while surfing … |
I guess 10 years after the general availability of a successor, it should be ok to drop HTTP/1.1+TLS1.1 - so no veto from me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I managed to connect with HTTP2 and HTTP w. keepalive.
Let's see how it works out for the bigger audience.
See openhab#1711 (comment). This change is not needed, the demo app starts fine without it. Signed-off-by: Florian Hotze <dev@florianhotze.com>
Sorry I was AFK for the holidays but it's a good move IMO. |
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/wget-and-sendhttpgetrequest-empty-response-differend/161321/6 |
Depends on openhab/openhab-core#4526.