Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Item channel links not properly initialized #1596

Closed
wborn opened this issue Aug 15, 2020 · 0 comments · Fixed by #1634
Closed

Item channel links not properly initialized #1596

wborn opened this issue Aug 15, 2020 · 0 comments · Fixed by #1634
Labels
bug An unexpected problem or unintended behavior of the Core
Milestone
3.0.0.M1

Comments

@wborn
Copy link
Member

wborn commented Aug 15, 2020 •
edited
Loading

A regression was introduced by #1385 causing ThingHandlers not to receive channel link/unlink events. As a result items do not always get proper state.

It's reproducible by installing the Astro Binding. Creating a Sun Thing then add some items to the model using the UI. If you then check the items in the UI or run items list the state remains null. As workaround you can restart the binding bundle resulting in the items getting proper state.
@wborn wborn added the bug An unexpected problem or unintended behavior of the Core label Aug 15, 2020
wborn added a commit to wborn/openhab-core that referenced this issue Sep 10, 2020
@wborn
Fix item channel links not properly initialized
46d93ac 
Fixes openhab#1596

Signed-off-by: Wouter Born <github@maindrain.net>
wborn added a commit to wborn/openhab-core that referenced this issue Sep 10, 2020
@wborn
Fix item channel links not properly initialized
28f2e42 
Fixes openhab#1596

Signed-off-by: Wouter Born <github@maindrain.net>
@wborn wborn mentioned this issue Sep 10, 2020
Merged
wborn added a commit to wborn/openhab-core that referenced this issue Sep 15, 2020
@wborn
Fix item channel links not properly initialized
58090bf 
Fixes openhab#1596

Signed-off-by: Wouter Born <github@maindrain.net>
wborn added a commit to wborn/openhab-core that referenced this issue Sep 19, 2020
@wborn
Fix item channel links not properly initialized
b8e96b6 
Fixes openhab#1596

Signed-off-by: Wouter Born <github@maindrain.net>
wborn added a commit to wborn/openhab-core that referenced this issue Sep 19, 2020
@wborn
Fix item channel links not properly initialized
8175e85 
Fixes openhab#1596

Signed-off-by: Wouter Born <github@maindrain.net>
@wborn wborn mentioned this issue Sep 23, 2020
Closed
7 tasks
wborn added a commit to wborn/openhab-addons that referenced this issue Sep 23, 2020
@wborn
[feed] Reenable itest
61fda63 
With these changes and working channelLink events (openhab/openhab-core#1596) the feed itest works again.

Signed-off-by: Wouter Born <github@maindrain.net>
@wborn wborn mentioned this issue Sep 23, 2020
Merged
kaikreuzer pushed a commit that referenced this issue Sep 24, 2020
@wborn
Fix item channel links not properly initialized (#1634)
2dd1a03 
* Fix item channel links not properly initialized
* Add ChannelLinkNotifierOSGiTest
* Send at most one channelLinked event per linked thing channel when activating ChannelLinkNotifier
* Send channelUnlinked event only if all items are unlinked
* Use Registry stream instead of getAll

Fixes #1596

Signed-off-by: Wouter Born <github@maindrain.net>
@robnielsen robnielsen mentioned this issue Sep 27, 2020
Closed
@wborn wborn added this to the 3.0 milestone Oct 6, 2020
@robnielsen robnielsen mentioned this issue Oct 9, 2020
Open
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this issue Jul 11, 2023
@wborn @splatch
Fix item channel links not properly initialized (openhab#1634)
7b4aa27 
* Fix item channel links not properly initialized
* Add ChannelLinkNotifierOSGiTest
* Send at most one channelLinked event per linked thing channel when activating ChannelLinkNotifier
* Send channelUnlinked event only if all items are unlinked
* Use Registry stream instead of getAll

Fixes openhab#1596

Signed-off-by: Wouter Born <github@maindrain.net>
GitOrigin-RevId: 2dd1a03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of the Core
Projects
None yet
Milestone
3.0.0.M1
Development

Successfully merging a pull request may close this issue.

Fix item channel links not properly initialized wborn/openhab-core
1 participant
@wborn