Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump esmock from 2.3.8 to 2.5.8 in /lambda #624

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 1, 2023

Bumps esmock from 2.3.8 to 2.5.8.

Release notes

Sourced from esmock's releases.

catch yarn PnP exception @​koshic

catch yarn PnP exception @​koshic

resolve critical error

mainly this issue resolves a critical error reported here iambumblehead/esmock#260

increment resolver

update resolver to latest version, resolves a resolution error that seems to have been introduced by a previous update from the past week.

support yarn PnP @​koshic

support yarn PnP @​koshic

call resolver with builtin moduleIds

This change affects custom resolvers, which are supported from v2.5.2. Per the spec, resolvers will be called with the builtin moduleIds, such as "node:path" and "fs"

add support for custom resolver

This release adds support for custom using a custom resolver. Specifically, a yarn PnP resolver can be passed to esmock, so that yarn PnP moduleIds can be resolved.

const modulePnP = await esmock('../src/parent.js', {
  '../src/PnPchild.js' : () => ['a', 'b']
}, null, {
  resolver: pnpapi.resolveRequest
})

lookup export type based on package.json type

This release updates the resolver to improve module resolution. See resolvewithplus tags v2.0.6 and v2.0.7.

Essentially, the resolver is updated to lookup the export type based on package.json type. For example, if package.json type is "module", the "import" definition is resolved, else if package.json type is undefined or "commonjs", the "require" definition is resolved. Previous versions of esmock usually reslved commonjs/require when those were defined and because most packages are published as commonjs, the issues resolved at this release likely did not affect anyone,

  • resolve "exports" before "main". The spec says: the "exports" field takes precedence over "main" in supported versions of Node.js. The updated resolver correctly returns "main" before "exports" (older resolver did not).
  • use package.json "type" to return "import" or "require". The older resolver did not read package.json type and returned incorrect "require" values for some packages. For example, if this inferno package where changed to use type "module", the older resolver would return "index.js" rather than "index.esm.js"

improve ts resolution

resolve existing ".ts" files, rather than ".js" files, when typescript is detected, thanks @​tpluscode

use initialize loader hook

esmock is updated to use the new "initialize" node loader hook https://nodejs.org/api/esm.html#initialize and, essentially, esmock no longer requires --loader=esmock when used with current releases of node

detect null and undefined loader-returned sources

Detects null AND undefined loader-returned source definitions

</tr></table> 

... (truncated)

Changelog

Sourced from esmock's changelog.

changelog

... (truncated)

Commits
  • 44b1420 Merge pull request #263 from iambumblehead/increment-package-version
  • b7637c1 update changelog and version
  • 58f3b6d Merge pull request #262 from iambumblehead/pnp-resolver-fix
  • f1135fb fix linter
  • a9b85ba catch exceptions generated by pnpapi
  • b95a699 increment package.json version
  • f305be3 Merge pull request #261 from iambumblehead/increment-resolvewithplus
  • 079e94d update link at CHANGELOG
  • b1bc6cb increment resolvewithplus
  • cf305cb Merge pull request #259 from iambumblehead/use-latest-node18-at-test-pipeline
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Nov 1, 2023
Bumps [esmock](https://github.com/iambumblehead/esmock) from 2.3.8 to 2.5.8.
- [Release notes](https://github.com/iambumblehead/esmock/releases)
- [Changelog](https://github.com/iambumblehead/esmock/blob/main/CHANGELOG.md)
- [Commits](iambumblehead/esmock@v2.3.8...v2.5.8)

---
updated-dependencies:
- dependency-name: esmock
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/lambda/esmock-2.5.8 branch from e716e23 to 9a05fac Compare November 2, 2023 00:31
@jsetton jsetton merged commit e762706 into main Nov 2, 2023
5 checks passed
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/lambda/esmock-2.5.8 branch November 2, 2023 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant