Convert to es module #542
Merged
Convert to es module #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jsetton <jeremy.setton@gmail.com>
|
Wow! |
|
@digitaldan What do you think? |
|
I think moving to ES modules sounds great. |
|
Great. Any objection if I merge this one? My local skill is working without any issues. The conversion is mostly syntax related with some minor refactoring to account for how import/export works with ES modules. |
|
Merging sounds good! As you mentioned the changes look mostly syntax related, and a lot of them, so i can't add much in terms of a review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS Lambda started to support ES modules from nodejs14 since the beginning of the year.
While looking at replacing the deprecated
requesthttp client package, there is an increasingly amount of maintained packages that are going ESM support only. I ended making the conversion to test some of the latest http client packages such asgotornode-fetch. In the end, I settled withaxiosfor the time being since it requires the least amount of changes in our codebase (Will be part of a separate PR). I am curious to see how the native Fetch API evolves.