-
-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major code refactoring #394
Conversation
As side notes, this change includes the support for the KeypadController interface but I wasn't able to get it working during my testing. I have a support ticket opened with the Alexa developer support team but I haven't got any response for couple weeks now. Also, since I don't own an echo device with a display 😄 , I wasn't able to properly test the support for the CameraStreamController interface. |
5a6b338
to
53ed32f
Compare
3013481
to
6f7c80b
Compare
4795bb5
to
13a527e
Compare
Since your last commit, i have not seen any issues, this is using a pretty extensive amount of devices and configurations. The "Blind" endpoint also work nicely. I have not yet spent time getting the camera endpoints up, our IPCamera binding uses a IP port per camera, which really complicates things. Otherwise this PR looks really really good! |
That's the reason I mentioned about the complexity in the usage documentation. Using NGINX, you would configure a HLS stream as follow. Different subdomains for each camera: server {
listen 443 ssl;
server_name cam1.myserver.com;
ssl_certificate cam1.myserver.com.crt;
ssl_certificate_key cam1.myserver.com.key;
ssl_protocols TLSv1 TLSv1.1 TLSv1.2;
auth_basic Restricted;
auth_basic_user_file htpasswd;
location / {
proxy_pass http://127.0.0.1:54321;
}
} Different location for each camera under a single subdomain: server {
listen 443 ssl;
server_name openhab.myserver.com;
ssl_certificate openhab.myserver.com.crt;
ssl_certificate_key openhab.myserver.com.key;
ssl_protocols TLSv1 TLSv1.1 TLSv1.2;
auth_basic Restricted;
auth_basic_user_file htpasswd;
location / {
proxy_pass http://127.0.0.1:8080;
}
location /cam1/ {
proxy_pass http://127.0.0.1:54321/;
}
location /cam2/ {
proxy_pass http://127.0.0.1:54322/;
}
}
Thanks 😄 Are you good with the new syntax? If so, I will make an announcement on the community forum asking for some feedback and starting a beta test. |
I think we are good for a beta test for sure ! Fyi, i just found an issue where one of my items was not discovered , it's using the existing syntax. I have not spent any time debugging why yet, i'll look this week when i have a sec. here's the item in case its clear to you:
|
|
dcd69a6
to
9b7d864
Compare
8276ada
to
a1b70b8
Compare
8bc9fe0
to
3580950
Compare
5bb0207
to
4997e3e
Compare
* introduced new item configuration syntax using device metadata concept * added new device capabilities for camera, door/window covering, fan, networking and vacuum * improved security arm state error handling * added input custom mappings support * added playback stop and thermostat hold/fan capabilities support * added new custom asset ids and semantic extensions * added switch support to mode generic capability * improved dimmer/rollershutter support for range value generic capability * updated test suite increasing code coverage * added support for ask-cli v2 using cloudformation deployer * improved ci integration with automated production release deployment * added github action to update repository locales on crowdin changes * deprecated item sensor concept for decouple state support on specific capabilities * removed item tag support for oh3.x * removed alexa smarthome api v2 support Signed-off-by: jsetton <jeremy.setton@gmail.com>
Fixes: #390, Fixes: #391
Changes