Add semantic state range validation check (#420)

Signed-off-by: jsetton <jeremy.setton@gmail.com>
openhab · Dec 2, 2021 · a4a7508 · a4a7508
1 parent 707c24a
commit a4a7508
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/lambda/alexa/smarthome/capabilities/rangeController.js b/lambda/alexa/smarthome/capabilities/rangeController.js
@@ -125,10 +125,10 @@ class RangeController extends AlexaCapability {
       const values = value && value.split(':', 2);
       // Add state mapping object if value(s) valid
       if (values && values.every((value) => value >= supportedRange[0] && value <= supportedRange[1])) {
-        if (values.length === 2) {
-          semantics.addStateToRange(name, { minimumValue: parseFloat(values[0]), maximumValue: parseFloat(values[1]) });
-        } else {
+        if (values.length === 1) {
           semantics.addStateToValue(name, parseFloat(values[0]));
+        } else if (values[0] < values[1]) {
+          semantics.addStateToRange(name, { minimumValue: parseFloat(values[0]), maximumValue: parseFloat(values[1]) });
         }
       }
     }

diff --git a/lambda/test/alexa/cases/discovery/other.test.js b/lambda/test/alexa/cases/discovery/other.test.js
@@ -98,7 +98,7 @@ module.exports = {
             unitOfMeasure: 'Invalid',
             // Invalid semantics (except playback action)
             actionMappings: 'Close=-1,Open=11,Lower=(-11),Raise=(+11),Stop=0',
-            stateMappings: 'Closed=-1,Open=0:11'
+            stateMappings: 'Closed=-1,Open=10:1'
           }
         }
       }
@@ -627,7 +627,7 @@ module.exports = {
             capabilityNames: ['@Setting.RangeValue'],
             supportedRange: [0, 10, 1],
             actionMappings: { Close: '-1', Open: '11', Lower: '(-11)', Raise: '(+11)' },
-            stateMappings: { Closed: '-1', Open: '0:11' }
+            stateMappings: { Closed: '-1', Open: '10:1' }
           },
           item: { name: 'range2', type: 'Number' }
         },