Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use renamed Units class #9267

Merged
merged 1 commit into from
Dec 7, 2020
Merged

Use renamed Units class #9267

merged 1 commit into from
Dec 7, 2020

Conversation

wborn
Copy link
Member

@wborn wborn commented Dec 6, 2020

@wborn
Use renamed Units class
7772be7 
Signed-off-by: Wouter Born <github@maindrain.net>
@wborn wborn added the awaiting other PR Depends on another PR label Dec 6, 2020
clinique
clinique approved these changes Dec 6, 2020
View reviewed changes
Copy link
Contributor

@clinique clinique left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mherwege
mherwege approved these changes Dec 7, 2020
View reviewed changes
Copy link
Contributor

@mherwege mherwege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaikreuzer kaikreuzer added rebuild Triggers Jenkins PR build and removed awaiting other PR Depends on another PR rebuild Triggers Jenkins PR build labels Dec 7, 2020
marcelrv
marcelrv approved these changes Dec 7, 2020
View reviewed changes
Copy link
Contributor

@marcelrv marcelrv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for miio binding

Cossey
Cossey approved these changes Dec 7, 2020
View reviewed changes
Copy link
Contributor

@Cossey Cossey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving changes to hp printer binding.

@kaikreuzer kaikreuzer merged commit ac6f089 into openhab:main Dec 7, 2020
@wborn wborn deleted the smarthome branch December 7, 2020 11:53
chrisonline pushed a commit to chrisonline/openhab-addons that referenced this pull request Dec 7, 2020
@wborn
Use renamed Units class (openhab#9267)
c4d3663 
Signed-off-by: Wouter Born <github@maindrain.net>
Signed-off-by: Christian Grasser <info@christiangrasser.at>
@wborn wborn added this to the 3.0.0.RC1 milestone Dec 13, 2020
boehan pushed a commit to boehan/openhab-addons that referenced this pull request Apr 12, 2021
@wborn @boehan
Use renamed Units class (openhab#9267)
c9ef7a4 
Signed-off-by: Wouter Born <github@maindrain.net>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
@wborn
Use renamed Units class (openhab#9267)
c959e73 
Signed-off-by: Wouter Born <github@maindrain.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skinah Skinah Skinah approved these changes

@pacive pacive pacive approved these changes

@mherwege mherwege mherwege approved these changes

@Cossey Cossey Cossey approved these changes

@marcelrv marcelrv marcelrv approved these changes

@crnjan crnjan crnjan approved these changes

@clinique clinique clinique approved these changes

@3cky 3cky Awaiting requested review from 3cky 3cky is a code owner

@9037568 9037568 Awaiting requested review from 9037568 9037568 is a code owner

@alexf2015 alexf2015 Awaiting requested review from alexf2015 alexf2015 is a code owner

@andrewfg andrewfg Awaiting requested review from andrewfg andrewfg is a code owner

@bern77 bern77 Awaiting requested review from bern77 bern77 is a code owner

@bjoernbrings bjoernbrings Awaiting requested review from bjoernbrings bjoernbrings is a code owner

@caffineehacker caffineehacker Awaiting requested review from caffineehacker caffineehacker is a code owner

@cdjackson cdjackson Awaiting requested review from cdjackson cdjackson is a code owner

@Confectrician Confectrician Awaiting requested review from Confectrician Confectrician is a code owner

@cpmeister cpmeister Awaiting requested review from cpmeister cpmeister is a code owner

@CrackerStealth CrackerStealth Awaiting requested review from CrackerStealth CrackerStealth is a code owner

@cschneider cschneider Awaiting requested review from cschneider cschneider is a code owner

@cweitkamp cweitkamp Awaiting requested review from cweitkamp cweitkamp is a code owner

@davidgraeff davidgraeff Awaiting requested review from davidgraeff

@DerOetzi DerOetzi Awaiting requested review from DerOetzi DerOetzi is a code owner

@digitaldan digitaldan Awaiting requested review from digitaldan digitaldan is a code owner

@FlorianSW FlorianSW Awaiting requested review from FlorianSW FlorianSW is a code owner

@fruggy83 fruggy83 Awaiting requested review from fruggy83 fruggy83 is a code owner

@fwolter fwolter Awaiting requested review from fwolter fwolter is a code owner

@gedejong gedejong Awaiting requested review from gedejong gedejong is a code owner

@gerrieg gerrieg Awaiting requested review from gerrieg

@hakan42 hakan42 Awaiting requested review from hakan42 hakan42 is a code owner

@Hilbrand Hilbrand Awaiting requested review from Hilbrand Hilbrand is a code owner

@hmerk hmerk Awaiting requested review from hmerk hmerk is a code owner

@J-N-K J-N-K Awaiting requested review from J-N-K J-N-K is a code owner

@jarlebh jarlebh Awaiting requested review from jarlebh

@kaikreuzer kaikreuzer Awaiting requested review from kaikreuzer kaikreuzer is a code owner

@kgoderis kgoderis Awaiting requested review from kgoderis kgoderis is a code owner

@kubawolanin kubawolanin Awaiting requested review from kubawolanin

@lewei50 lewei50 Awaiting requested review from lewei50 lewei50 is a code owner

@lolodomo lolodomo Awaiting requested review from lolodomo lolodomo is a code owner

@markus7017 markus7017 Awaiting requested review from markus7017 markus7017 is a code owner

@marvkis marvkis Awaiting requested review from marvkis marvkis is a code owner

@mgeramb mgeramb Awaiting requested review from mgeramb mgeramb is a code owner

@mhilbush mhilbush Awaiting requested review from mhilbush mhilbush is a code owner

@msteigenberger msteigenberger Awaiting requested review from msteigenberger msteigenberger is a code owner

@pail23 pail23 Awaiting requested review from pail23 pail23 is a code owner

@paulianttila paulianttila Awaiting requested review from paulianttila paulianttila is a code owner

@reyem reyem Awaiting requested review from reyem reyem is a code owner

@robnielsen robnielsen Awaiting requested review from robnielsen

@SamuelBrucksch SamuelBrucksch Awaiting requested review from SamuelBrucksch SamuelBrucksch is a code owner

@seime seime Awaiting requested review from seime seime is a code owner

@ssalonen ssalonen Awaiting requested review from ssalonen ssalonen is a code owner

@theater theater Awaiting requested review from theater theater is a code owner

@Wire82 Wire82 Awaiting requested review from Wire82 Wire82 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0.RC1
Development

Successfully merging this pull request may close these issues.
9 participants
@wborn @clinique @crnjan @marcelrv @Cossey @mherwege @pacive @Skinah @kaikreuzer