[miio] channels removal #9237
Merged
[miio] channels removal #9237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
|
@cpmeister wrt to the channels not being available in your binding, I see the ChannelProvider being queried when I do the check for the availability of the channel https://github.com/openhab/openhab-addons/blob/main/bundles/org.openhab.binding.miio/src/main/java/org/openhab/binding/miio/internal/handler/MiIoBasicHandler.java#L468 maybe that is causing a refresh of the available channels in the framework and the reason I did not have similar issue |
cpmeister
approved these changes
Dec 7, 2020
cpmeister
added
the
enhancement
chrisonline
pushed a commit
to chrisonline/openhab-addons
that referenced
this pull request
Dec 7, 2020
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> Signed-off-by: Christian Grasser <info@christiangrasser.at>
boehan
pushed a commit
to boehan/openhab-addons
that referenced
this pull request
Apr 12, 2021
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures channels are removed if you switch between various models, while preserving the standard channels available to all models
Signed-off-by: Marcel Verpaalen marcel@verpaalen.com