[icalendar] Fix race condition while initialization of EventFilterHandler #9230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dler Should fix openhab#9029. The channels do not get updated as the known channels by the binding where only updated if Bridge was already online while initializing EventFilterHandler. Also added a bit more output. Signed-off-by: Michael Wodniok <michi@noorganization.org>
cpmeister
requested changes
Dec 4, 2020
...icalendar/src/main/java/org/openhab/binding/icalendar/internal/handler/ICalendarHandler.java
Outdated
Show resolved
Hide resolved
...alendar/src/main/java/org/openhab/binding/icalendar/internal/handler/EventFilterHandler.java
Outdated
Show resolved
Hide resolved
As suggested by @cpmeister Signed-Off-By: Michael Wodniok <michi@noorganization.org> Co-authored-by: Connor Petty <mistercpp2000@gmail.com>
…ed by @cpmeister Signed-off-by: Michael Wodniok <michi@noorganization.org>
cpmeister
approved these changes
Dec 5, 2020
chrisonline
pushed a commit
to chrisonline/openhab-addons
that referenced
this pull request
Dec 7, 2020
…dler (openhab#9230) * [icalendar] Fix race condition while initialization of EventFilterHandler Should fix openhab#9029. The channels do not get updated as the known channels by the binding where only updated if Bridge was already online while initializing EventFilterHandler. Also added a bit more output. * [icalendar] use implicit conversion to string for logging Signed-off-by: Michael Wodniok <michi@noorganization.org> Co-authored-by: Connor Petty <mistercpp2000+gitsignoff@gmail.com> Signed-off-by: Christian Grasser <info@christiangrasser.at>
boehan
pushed a commit
to boehan/openhab-addons
that referenced
this pull request
Apr 12, 2021
…dler (openhab#9230) * [icalendar] Fix race condition while initialization of EventFilterHandler Should fix openhab#9029. The channels do not get updated as the known channels by the binding where only updated if Bridge was already online while initializing EventFilterHandler. Also added a bit more output. * [icalendar] use implicit conversion to string for logging Signed-off-by: Michael Wodniok <michi@noorganization.org> Co-authored-by: Connor Petty <mistercpp2000+gitsignoff@gmail.com>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
…dler (openhab#9230) * [icalendar] Fix race condition while initialization of EventFilterHandler Should fix openhab#9029. The channels do not get updated as the known channels by the binding where only updated if Bridge was already online while initializing EventFilterHandler. Also added a bit more output. * [icalendar] use implicit conversion to string for logging Signed-off-by: Michael Wodniok <michi@noorganization.org> Co-authored-by: Connor Petty <mistercpp2000+gitsignoff@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #9029. The channels do not get updated as the known channels by the binding where only updated if Bridge was already online while initializing EventFilterHandler. Even if it does not fix the issue, the race condition is is fixed.
Also added a bit more output.
Signed-off-by: Michael Wodniok michi@noorganization.org