[bluetooth.enoceanble] Initial contribution EnOcean BLE Binding #9223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick Fink <mail@pfink.de>
cpmeister
requested changes
Dec 4, 2020
cpmeister
requested changes
Dec 4, 2020
...n/java/org/openhab/binding/bluetooth/enoceanble/internal/EnoceanBleDiscoveryParticipant.java
Outdated
Show resolved
Hide resolved
...n/java/org/openhab/binding/bluetooth/enoceanble/internal/EnoceanBleDiscoveryParticipant.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/openhab/binding/bluetooth/enoceanble/internal/EnoceanBleHandlerFactory.java
Outdated
Show resolved
Hide resolved
cpmeister
added
the
new binding
Signed-off-by: Patrick Fink <mail@pfink.de> Co-authored-by: Connor Petty <mistercpp2000@gmail.com>
What do you mean? Should I do something here? |
|
Sorry, I should have been more clear. All bindings require adding themselves to the CODEOWNERS file so that github can know which users to notify if another PR tries to change the code in the binding. The footer.xml change is something special to bluetooth bindings and modbus bindings in order for them to be included in the release bundle. Without it users won't have access to your binding after installing the bluetooth binding. So yes, you need to add an entry for this binding in both files. |
cpmeister
requested changes
Dec 4, 2020
bundles/org.openhab.binding.bluetooth.enoceanble/src/main/feature/feature.xml
Outdated
Show resolved
Hide resolved
Signed-off-by: Patrick Fink <mail@pfink.de>
Signed-off-by: Patrick Fink <mail@pfink.de>
Signed-off-by: Patrick Fink <mail@pfink.de>
|
All requested changes done. |
cpmeister
requested changes
Dec 4, 2020
...rc/main/java/org/openhab/binding/bluetooth/enoceanble/internal/EnoceanBleHandlerFactory.java
Outdated
Show resolved
Hide resolved
cpmeister
requested changes
Dec 4, 2020
Signed-off-by: Patrick Fink <mail@pfink.de>
Signed-off-by: Patrick Fink <mail@pfink.de>
|
All requested changes done. |
cpmeister
approved these changes
Dec 5, 2020
|
Thanks for the light speed review & approval @cpmeister! :) |
chrisonline
pushed a commit
to chrisonline/openhab-addons
that referenced
this pull request
Dec 7, 2020
…hab#9223) * [bluetooth.enoceanble] Initial contribution EnOcean BLE Binding Signed-off-by: Patrick Fink <mail@pfink.de> * Put @nullable annotation inline Signed-off-by: Patrick Fink <mail@pfink.de> Co-authored-by: Connor Petty <mistercpp2000@gmail.com> * [bluetooth.enoceanble] Add binding to CODEOWNERS Signed-off-by: Patrick Fink <mail@pfink.de> * [bluetooth.enoceanble] Remove obsolete transport serial feature Signed-off-by: Patrick Fink <mail@pfink.de> * [bluetooth.enoceanble] Add binding to footer.xml Signed-off-by: Patrick Fink <mail@pfink.de> * [bluetooth.enoceanble] Replace ruuvitag leftovers Signed-off-by: Patrick Fink <mail@pfink.de> * [bluetooth.enoceanble] Remove tinyB reference Signed-off-by: Patrick Fink <mail@pfink.de> Co-authored-by: Connor Petty <mistercpp2000@gmail.com> Signed-off-by: Christian Grasser <info@christiangrasser.at>
boehan
pushed a commit
to boehan/openhab-addons
that referenced
this pull request
Apr 12, 2021
…hab#9223) * [bluetooth.enoceanble] Initial contribution EnOcean BLE Binding Signed-off-by: Patrick Fink <mail@pfink.de> * Put @nullable annotation inline Signed-off-by: Patrick Fink <mail@pfink.de> Co-authored-by: Connor Petty <mistercpp2000@gmail.com> * [bluetooth.enoceanble] Add binding to CODEOWNERS Signed-off-by: Patrick Fink <mail@pfink.de> * [bluetooth.enoceanble] Remove obsolete transport serial feature Signed-off-by: Patrick Fink <mail@pfink.de> * [bluetooth.enoceanble] Add binding to footer.xml Signed-off-by: Patrick Fink <mail@pfink.de> * [bluetooth.enoceanble] Replace ruuvitag leftovers Signed-off-by: Patrick Fink <mail@pfink.de> * [bluetooth.enoceanble] Remove tinyB reference Signed-off-by: Patrick Fink <mail@pfink.de> Co-authored-by: Connor Petty <mistercpp2000@gmail.com>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
…hab#9223) * [bluetooth.enoceanble] Initial contribution EnOcean BLE Binding Signed-off-by: Patrick Fink <mail@pfink.de> * Put @nullable annotation inline Signed-off-by: Patrick Fink <mail@pfink.de> Co-authored-by: Connor Petty <mistercpp2000@gmail.com> * [bluetooth.enoceanble] Add binding to CODEOWNERS Signed-off-by: Patrick Fink <mail@pfink.de> * [bluetooth.enoceanble] Remove obsolete transport serial feature Signed-off-by: Patrick Fink <mail@pfink.de> * [bluetooth.enoceanble] Add binding to footer.xml Signed-off-by: Patrick Fink <mail@pfink.de> * [bluetooth.enoceanble] Replace ruuvitag leftovers Signed-off-by: Patrick Fink <mail@pfink.de> * [bluetooth.enoceanble] Remove tinyB reference Signed-off-by: Patrick Fink <mail@pfink.de> Co-authored-by: Connor Petty <mistercpp2000@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Binding: EnOcean BLE
Binding is ready for your review. One point I was wondering about if I should add the Bluez Bridge as a supported bridge type, as the rockers do not work well with Bluez as mentioned in the docs (they work, but not all events are getting through, quality is way too bad for production use). Anyhow, I don't wanted to prohibit trying the Bluez Binding out, so I left it there - but I'm open to other opinions about that.
Signed-off-by: Patrick Fink mail@pfink.de