Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[amazonechocontrol] HandlerThermostatController #9212

Merged
merged 3 commits into from
Dec 5, 2020
Merged

[amazonechocontrol] HandlerThermostatController #9212

merged 3 commits into from
Dec 5, 2020

Conversation

sonic74
Copy link
Contributor

@sonic74 sonic74 commented Dec 3, 2020

No description provided.

@sonic74 sonic74 requested a review from mgeramb as a code owner December 3, 2020 15:19
@sonic74
HandlerThermostatController
5eb6723 
Signed-off-by: Sven Killig <sven@killig.de>
@Skinah Skinah changed the title HandlerThermostatController [amazonechocontrol] HandlerThermostatController Dec 4, 2020
@Skinah
Copy link
Contributor

Skinah commented Dec 4, 2020

  1. Please put the name of the addon in square brackets in the title. I edited it for you.
  2. You may want to review the use of 'logger.error' as error level is reserved for when a critical error occurs that prevents openHAB from working correctly. See here.
    https://www.openhab.org/docs/developer/guidelines.html#f-logging

@sonic74
replaced error() with warn()
137027c 
Signed-off-by: Sven Killig <sven@killig.de>
@sonic74
Copy link
Contributor Author

sonic74 commented Dec 4, 2020 •
edited
Loading

  1. Please put the name of the addon in square brackets in the title. I edited it for you.

Thanks!

  1. You may want to review the use of 'logger.error' as error level is reserved for when a critical error occurs that prevents openHAB from working correctly. See here.
    https://www.openhab.org/docs/developer/guidelines.html#f-logging

I replaced error() with warn().

J-N-K
J-N-K requested changes Dec 5, 2020
View reviewed changes
Copy link
Member

@J-N-K J-N-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM.

...azonechocontrol/src/main/java/org/openhab/binding/amazonechocontrol/internal/Connection.java Outdated Show resolved Hide resolved
@sonic74
reverted logger changes because of openhab#9241
290a0f9 
Signed-off-by: Sven Killig <sven@killig.de>
@sonic74 sonic74 requested a review from J-N-K December 5, 2020 13:35
J-N-K
J-N-K approved these changes Dec 5, 2020
View reviewed changes
Copy link
Member

@J-N-K J-N-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks. Just waiting for Jenkins before merge.

@J-N-K
Copy link
Member

J-N-K commented Dec 5, 2020

Jenkins fails unrelated

@J-N-K J-N-K merged commit 68dd556 into openhab:main Dec 5, 2020
@J-N-K J-N-K added this to the 3.0.0.M5 milestone Dec 5, 2020
@J-N-K J-N-K added the enhancement An enhancement or new feature for an existing add-on label Dec 5, 2020
chrisonline pushed a commit to chrisonline/openhab-addons that referenced this pull request Dec 7, 2020
@sonic74
[amazonechocontrol] HandlerThermostatController (openhab#9212)
5517641 
* HandlerThermostatController

Signed-off-by: Sven Killig <sven@killig.de>
Signed-off-by: Christian Grasser <info@christiangrasser.at>
boehan pushed a commit to boehan/openhab-addons that referenced this pull request Apr 12, 2021
@sonic74 @boehan
[amazonechocontrol] HandlerThermostatController (openhab#9212)
a3ab639 
* HandlerThermostatController

Signed-off-by: Sven Killig <sven@killig.de>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
@sonic74
[amazonechocontrol] HandlerThermostatController (openhab#9212)
30388f2 
* HandlerThermostatController

Signed-off-by: Sven Killig <sven@killig.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J-N-K J-N-K J-N-K approved these changes

@mgeramb mgeramb Awaiting requested review from mgeramb mgeramb is a code owner

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
3.0.0.M5
Development

Successfully merging this pull request may close these issues.
3 participants
@sonic74 @Skinah @J-N-K