[powermax] Update README.md #9207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added some comments on how to enable bypass switching Signed-off-by: JuanFran Adame <juanfran.adame@gmail.com>
lolodomo
reviewed
Dec 4, 2020
| @@ -155,6 +155,7 @@ In case it fails after all the retries, you still have the option to later trigg | |||
| - Visonic does not provide a specification of the RS232 protocol and, thus, use this binding at your own risk. | |||
| - The binding is not able to arm/disarm a particular partition. | |||
| - The compatibility of the binding with the Powermaster alarm panel series is probably only partial. | |||
| - In order to be able to bypass zones, `Bypass` parameter at `Panel parameters` at PowerMax must be set to `manual bypass` as described in section 4.4.8 in installer's manual (Installer mode -> 4. Define Panel -> 8. Bypass). | |||
There was a problem hiding this comment.
The message is too much specific to a model.
But you are right, to be able to use this feature, there is a setting to change in the alarm panel to enable the feature, this is the case even for a PowermaxPro.
There was a problem hiding this comment.
I propose something like "In order to be able to bypass zones, you must first enable this feature by updating your panel configuration. Look at your installer's manual."
Agreed changes to documentation
lolodomo
approved these changes
Dec 6, 2020
|
I changed as you proposed |
fwolter
approved these changes
Dec 6, 2020
There was a problem hiding this comment.
LGTM. Next time, please sign-off your commits: https://www.openhab.org/docs/developer/contributing.html#sign-your-work Applying the small patch exception.
chrisonline
pushed a commit
to chrisonline/openhab-addons
that referenced
this pull request
Dec 7, 2020
* Update README.md Added some comments on how to enable bypass switching Signed-off-by: JuanFran Adame <juanfran.adame@gmail.com> Signed-off-by: Christian Grasser <info@christiangrasser.at>
boehan
pushed a commit
to boehan/openhab-addons
that referenced
this pull request
Apr 12, 2021
* Update README.md Added some comments on how to enable bypass switching Signed-off-by: JuanFran Adame <juanfran.adame@gmail.com>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
* Update README.md Added some comments on how to enable bypass switching Signed-off-by: JuanFran Adame <juanfran.adame@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some comments on how to enable bypass switching