[ipcamera] Improve ONVIF discovery and bug fixes. #9199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Signed-off-by: Matthew Skinner <matt@pcmus.com>
cpmeister
requested changes
Dec 4, 2020
...org.openhab.binding.ipcamera/src/main/java/org/openhab/binding/ipcamera/internal/Ffmpeg.java
Outdated
Show resolved
Hide resolved
...b.binding.ipcamera/src/main/java/org/openhab/binding/ipcamera/internal/HikvisionHandler.java
Outdated
Show resolved
Hide resolved
…/binding/ipcamera/internal/Ffmpeg.java Signed-off-by: Matthew Skinner <matt@pcmus.com> Co-authored-by: Connor Petty <mistercpp2000@gmail.com>
Signed-off-by: Matthew Skinner <matt@pcmus.com>
cpmeister
reviewed
Dec 5, 2020
| openChannels.add(datagramChannel); | ||
| } | ||
| if (!openChannels.isEmpty()) { | ||
| openChannels.writeAndFlush(wsDiscovery()); |
There was a problem hiding this comment.
Does this still return a future that you should wait for? Or do you not need to do that anymore?
There was a problem hiding this comment.
I don’t need to use a future as it gives no benefits and only increases code length.
cpmeister
approved these changes
Dec 7, 2020
cpmeister
added
the
enhancement
chrisonline
pushed a commit
to chrisonline/openhab-addons
that referenced
this pull request
Dec 7, 2020
* Fix Offline detection and Improve discovery. * Motion options bug fix. * Message content bug fix. * Fix all handlers to process all chunks as one. * Remove password from FFmpeg command log. Signed-off-by: Matthew Skinner <matt@pcmus.com> Signed-off-by: Christian Grasser <info@christiangrasser.at>
boehan
pushed a commit
to boehan/openhab-addons
that referenced
this pull request
Apr 12, 2021
* Fix Offline detection and Improve discovery. * Motion options bug fix. * Message content bug fix. * Fix all handlers to process all chunks as one. * Remove password from FFmpeg command log. Signed-off-by: Matthew Skinner <matt@pcmus.com>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
* Fix Offline detection and Improve discovery. * Motion options bug fix. * Message content bug fix. * Fix all handlers to process all chunks as one. * Remove password from FFmpeg command log. Signed-off-by: Matthew Skinner <matt@pcmus.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closed #9167
Closed #9023
Closed #9022
This PR changes the following: