[comfoair] Update README.md to refelect recent change. #9193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the ComfoairControl item changed from Number to Switch in the new binding also the sitemap mapping should OFF=CC and ON=APP instead of 0 and 1.
fwolter
approved these changes
Dec 6, 2020
There was a problem hiding this comment.
LGTM. Next time, please sign-off your commits: https://www.openhab.org/docs/developer/contributing.html#sign-your-work Applying the small patch exception.
fwolter
pushed a commit
that referenced
this pull request
Dec 6, 2020
As the ComfoairControl item changed from Number to Switch in the new binding also the sitemap mapping should OFF=CC and ON=APP instead of 0 and 1. (cherry picked from commit ad2a1e3)
|
Just saw this was filed against the wrong branch. Should be |
chrisonline
pushed a commit
to chrisonline/openhab-addons
that referenced
this pull request
Dec 7, 2020
As the ComfoairControl item changed from Number to Switch in the new binding also the sitemap mapping should OFF=CC and ON=APP instead of 0 and 1. (cherry picked from commit ad2a1e3) Signed-off-by: Christian Grasser <info@christiangrasser.at>
boehan
pushed a commit
to boehan/openhab-addons
that referenced
this pull request
Apr 12, 2021
As the ComfoairControl item changed from Number to Switch in the new binding also the sitemap mapping should OFF=CC and ON=APP instead of 0 and 1. (cherry picked from commit ad2a1e3)
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
As the ComfoairControl item changed from Number to Switch in the new binding also the sitemap mapping should OFF=CC and ON=APP instead of 0 and 1. (cherry picked from commit ad2a1e3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the ComfoairControl item changed from Number to Switch in the new binding also the sitemap mapping should OFF=CC and ON=APP instead of 0 and 1. I found this out today when running some tests together with Hans Boehm.
Refer to: https://community.openhab.org/t/comfoair-new-comfoair-binding/92891/81