Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kostal-inverter] added troubleshooting information for authentication issues with 3rd gen kostal-inverter binding #7581

Merged
merged 1 commit into from
May 11, 2020

Conversation

Bonifatius94
Copy link

[kostal-inverter] added troubleshooting information to the README file for authentication issues with 3rd gen kostal-inverter binding

I've added a little section to the README file of the kostal-inverter binding indicating that the third generation devices (SCB) require Java's strong cryptography to be enabled for successfully establishing connections. Moreover I've added some lines that describe how to enable strong cryptography (including legal law restrictions for some countries).

Maybe you could re-arrange the positioning of my text and put it into a troubleshooting section. The content should be fine.

There were no changes made to the source code, just to the documentation. And I've also tested my fix instructions with the latest official docker image of openHAB.

…n issues with 3rd gen kostal-inverter binding

Signed-off-by: Marco Tröster <marco@troester-gmbh.de>
@Bonifatius94
Copy link
Author

sorry for my two failed merge requests. this is my first participation on a github project with DCO n stuff ...

@TravisBuddy
Copy link

Travis tests were successful

Hey @Bonifatius94,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

Copy link
Contributor

@cpmeister cpmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpmeister
Copy link
Contributor

Thanks for the contribution!

@cpmeister cpmeister merged commit 7081b74 into openhab:2.5.x May 11, 2020
@cpmeister cpmeister added this to the 2.5.5 milestone May 11, 2020
LoungeFlyZ pushed a commit to LoungeFlyZ/openhab2-addons that referenced this pull request Jun 8, 2020
…n issues with 3rd gen kostal-inverter binding (openhab#7581)

Signed-off-by: Marco Tröster <marco@troester-gmbh.de>
J-N-K pushed a commit to J-N-K/openhab-addons that referenced this pull request Jul 14, 2020
…n issues with 3rd gen kostal-inverter binding (openhab#7581)

Signed-off-by: Marco Tröster <marco@troester-gmbh.de>
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Jul 26, 2020
…n issues with 3rd gen kostal-inverter binding (openhab#7581)

Signed-off-by: Marco Tröster <marco@troester-gmbh.de>
Signed-off-by: CSchlipp <christian@schlipp.de>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
…n issues with 3rd gen kostal-inverter binding (openhab#7581)

Signed-off-by: Marco Tröster <marco@troester-gmbh.de>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
…n issues with 3rd gen kostal-inverter binding (openhab#7581)

Signed-off-by: Marco Tröster <marco@troester-gmbh.de>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
…n issues with 3rd gen kostal-inverter binding (openhab#7581)

Signed-off-by: Marco Tröster <marco@troester-gmbh.de>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
…n issues with 3rd gen kostal-inverter binding (openhab#7581)

Signed-off-by: Marco Tröster <marco@troester-gmbh.de>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
…n issues with 3rd gen kostal-inverter binding (openhab#7581)

Signed-off-by: Marco Tröster <marco@troester-gmbh.de>
Signed-off-by: Daan Meijer <daan@studioseptember.nl>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
…n issues with 3rd gen kostal-inverter binding (openhab#7581)

Signed-off-by: Marco Tröster <marco@troester-gmbh.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants