Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[evcc] Adjust to evcc 0.125.0 API changes #16660

Merged
merged 8 commits into from
Apr 20, 2024

Conversation

MikeTheTux
Copy link
Contributor

@MikeTheTux MikeTheTux commented Apr 17, 2024

Implementation of #16658 due to evcc-io/evcc#13463.

The change is backward compatible.

…ed' and 'pvConfigured'

Signed-off-by: Michael Weger <weger.michael@gmx.net>
Signed-off-by: Michael Weger <weger.michael@gmx.net>
Signed-off-by: Michael Weger <weger.michael@gmx.net>
@MikeTheTux MikeTheTux requested a review from lsiepel April 17, 2024 18:56
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, thanks!
Please have a look at my comments.

@florian-h05
Copy link
Contributor

Please also update the README wrt evcc version.

@MikeTheTux
Copy link
Contributor Author

Please also update the README wrt evcc version.

Done. Please check if I should keep the update as it is or simplify it (mention version 125.0 only)

Signed-off-by: Michael Weger <weger.michael@gmx.net>
Signed-off-by: Michael Weger <weger.michael@gmx.net>
This reverts commit aa0c3c0.

Signed-off-by: Michael Weger <weger.michael@gmx.net>
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your changes!

Just two minor comments left.

@florian-h05 florian-h05 changed the title [evcc] Implement latest evcc rest-API changes [evcc] Adjust to evcc 0.125.1 API changes Apr 20, 2024
@florian-h05 florian-h05 changed the title [evcc] Adjust to evcc 0.125.1 API changes [evcc] Adjust to evcc 0.125.0 API changes Apr 20, 2024
Signed-off-by: Michael Weger <weger.michael@gmx.net>
Signed-off-by: Michael Weger <weger.michael@gmx.net>
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@openhab/add-ons-maintainers Can you please merge?

@lsiepel lsiepel merged commit 6db28f5 into openhab:main Apr 20, 2024
3 checks passed
@lsiepel lsiepel added the enhancement An enhancement or new feature for an existing add-on label Apr 20, 2024
@lsiepel lsiepel added this to the 4.2 milestone Apr 20, 2024
lo92fr pushed a commit to lo92fr/openhab-addons that referenced this pull request Apr 30, 2024
* avoid deprecated parameters evcc rest API parameters 'batteryConfigured' and 'pvConfigured'

Signed-off-by: Michael Weger <weger.michael@gmx.net>
florian-h05 pushed a commit to florian-h05/openhab-addons that referenced this pull request May 30, 2024
* avoid deprecated parameters evcc rest API parameters 'batteryConfigured' and 'pvConfigured'

Signed-off-by: Michael Weger <weger.michael@gmx.net>
(cherry picked from commit 6db28f5)
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/evcc-binding-electric-vehicle-charging-control-backport-4-1-0-4-2-0/135209/1

psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Jun 15, 2024
* avoid deprecated parameters evcc rest API parameters 'batteryConfigured' and 'pvConfigured'

Signed-off-by: Michael Weger <weger.michael@gmx.net>
Signed-off-by: Paul Smedley <paul@smedley.id.au>
pgfeller pushed a commit to pgfeller/openhab-addons that referenced this pull request Sep 29, 2024
* avoid deprecated parameters evcc rest API parameters 'batteryConfigured' and 'pvConfigured'

Signed-off-by: Michael Weger <weger.michael@gmx.net>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
* avoid deprecated parameters evcc rest API parameters 'batteryConfigured' and 'pvConfigured'

Signed-off-by: Michael Weger <weger.michael@gmx.net>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
* avoid deprecated parameters evcc rest API parameters 'batteryConfigured' and 'pvConfigured'

Signed-off-by: Michael Weger <weger.michael@gmx.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants