chore: update hydrogen alpine #6752
Conversation
…or subsequent jobs
FRM-1320 Triage, investigate “High” vulnerabilities as listed in Snyk
Description Remediate if deemed necessary. Find all the listed vulnerabilities through https://app.snyk.io/. Link FormSG to your account if you have not. Problem
Solution Determine if we can follow recommendation proposed above Additional context This has been something that we keep saying that we want to do for a few sprints, but have not had time to handle this. |
sebastianwzq
temporarily deployed
to
staging-alt2
GitHub Actions
Inactive
sebastianwzq
temporarily deployed
to
staging
GitHub Actions
Inactive
| @@ -26,7 +26,7 @@ | |||
| "scripts": { | |||
| "postinstall": "npm run postinstall:frontend && npm run postinstall:shared", | |||
| "test": "npm run test:backend && npm run test:frontend", | |||
| "test:backend": "env-cmd -f __tests__/setup/.test-env jest --coverage --maxWorkers=4", | |||
| "test:backend": "env-cmd -f __tests__/setup/.test-env jest --coverage --maxWorkers=4 --testTimeout=90000", | |||
There was a problem hiding this comment.
Was this needed to reduce BE test flakiness? 😮 This timeout is for individual tests, right?
There was a problem hiding this comment.
Yes, timeout is for individual test, Jest performance declined with newer node versions so I increased the timeout until a fix is available
There was a problem hiding this comment.
/suggestion: there is already existing config in jest.config.js, suggestion to update there instead of passing in as cli arg (or passing in CLI is fine too, but we should then remove from jest.config)
There was a problem hiding this comment.
Sure, will move over in the second part of the MR
Problem
Resolve node vulnerabilities raised by Snyk
Closes FRM-1320
Solution
Update docker images to use hydrogen-alpine3.16 to hydrogen-alpine3.18
Node version for hydrogen-alpine3.16 is 18.12.1 and node version for hydrogen-alpine3.18 is 18.17.1
Node version changelog
Updating Chromium as the Chromium version currently available on alpine3.18 is 115.0.5790.170-r0
[Update] Updating Chromium as the Chromium version currently available on alpine3.18 is 117.0.5938.62-r0
From the puppeteer issue discussion thread, there are tight version requirements between Chromium and puppeteer. We can check for the version mapping between Chromium and puppeteer by looking at the puppeteer's release notes.
[Update] From the puppeteer issue discussion thread, there are tight version requirements between Chromium and puppeteer. We can check for the version mapping between Chromium and puppeteer by looking at the puppeteer's release notes.
Upgraded our CI from node 14 to node 18. Had to make some changes to our CI due to the higher memory consumption causing tests to exit before completion. Concretely,
Breaking Changes
Tests