fix: date picker calendar select correct date in negative UTC offset timezones #5731
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue brought up in #5510. It seems to be caused modifications to date in
handleDateChange
.demo:
https://user-images.githubusercontent.com/39296145/216810183-b8ca0036-416b-45c1-be25-530eb6c90729.mov
zonedTimeToUtc
zonedTimeToUtc
returns equivalent datetime in UTC after comparing local timezone to 'UTC' timeFor better visualisation:
BEFORE
AFTER
Solution
Instead of specifying 'UTC' to
zoneTimeToUtc
, provide the local timezone instead. This fixes the issue but I'm not actually sure whether its correct as it feels like its just reversing the use ofzoneTimeToUtc
. More info at marnusw/date-fns-tz.js#174I believe this can be discussed further @karrui
Breaking Changes
No - this PR is backwards compatible