Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples 1 and 2 of the tileMatrixSet schema in Clause 8.3.2 need to be updated #140

Closed
ghobona opened this issue Nov 29, 2022 · 7 comments

Comments

@ghobona
Copy link
Contributor

ghobona commented Nov 29, 2022

Examples 1 and 2 of the tileMatrixSet schema need to be updated to match the schemas.opengis.net

Verified by @jerstlouis that tileMatrixSet.yaml at schemas.opengis.net is up to date.

@ghobona ghobona changed the title Examples 1 and 2 of the tileMatrixSet schema need to be updated Examples 1 and 2 of the tileMatrixSet schema in Clause 8.3.2 need to be updated Nov 30, 2022
@ghobona
Copy link
Contributor Author

ghobona commented Nov 30, 2022

This issue is more about Example 2.

See attached.

Screenshot 2022-11-30 at 11 09 43

@cportele
Copy link
Member

But the Tile Matrix Sets resource does not contain the Tile Matrix Set resources themselves, but a list of them with basic information (id, link, title, canonical URI). I think the standard is correct.

Well, with the exception that the schemas are shown as "examples", but this is probably a Metanorma issue?

@ghobona
Copy link
Contributor Author

ghobona commented Nov 30, 2022

The word "example" will be removed from the caption in the next revision.

@jerstlouis
Copy link
Member

jerstlouis commented Nov 30, 2022

@cportele This particular schema is about the tile matrix set definition , it is for the recommendation (not requirement) for definitions at /tileMatrixSets/{tileMatrixSetId}.
So in this case it is the tileMatrixSet schema which correctly uses simply uri (because it is the URI for itself). The example below it correctly uses URI.

It is just that embedded schema in the spec which was not updated after a mistake was corrected.
It is correct in both the tiles OpenAPI examples and in the 2DTMS schemas.

At /tileMatrixSets, it is an array of objects (with rel: self), so the properties are consistent with the full definitions at /tileMatrixSets/{tileMatrixSetId}.

@cportele
Copy link
Member

@jerstlouis - ok, so the example 3 is correct and the schema 2 needs to be fixed in a corrigendum. I will update ldproxy, which currently still uses schema 2.

cportele added a commit to ldproxy/ldproxy that referenced this issue Nov 30, 2022
@joanma747
Copy link
Contributor

joanma747 commented Dec 2, 2022

First: The "example 2" says: "id-link from OGC API - Common". I have not been able to find it in any of the API common materials. So this reference to "commons" should be removed. So I'm now in the assumption that this schema is "API tiles specific".

Secondly: The property is called "tileMatrixSetURI" because it want to be consistent with the 2dTMS metadata where this file:
.../tms/2.0/json/tileSet.json"

says:

"tileMatrixSetURI":
		{
			"description": "Reference to a Tile Matrix Set on an official source for Tile Matrix Sets such as the OGC-NA definition server (http://www.opengis.net/def/tms). Required if the tile matrix set is registered on an open official source.",
			"type": "string",
			"format": "uri"
		},

The intention is to reference an official source of TileMatrixSets so it is called "tileMatrixSetURI".

Since commonly I fail to convince anyone with this kind of arguments, I have changed tileMatrixSetURI to uri and removed any reference to OGC API Common.

The whole section is not normative so In my opinion we can consider this an editorial mistake.

@jerstlouis
Copy link
Member

jerstlouis commented Dec 2, 2022

@joanma747 I believe this reference to OGC API - Common was a "Replace All" that went wrong, where originally it was simply said "Common tilematrixset".

It is called uri (already correct in both the 2DTMS tileMatrixSet.json and the Tiles OpenAPI tileMatrixSet.yaml), because the self is the TileMatrixSet, so it would be redundant to say tileMatrixSetURI.

This particular schema is not OGC API - Tiles specific, it is from 2DTMS.
It is the YAML version of https://schemas.opengis.net/tms/2.0/json/tileMatrixSet.json .

The intention is to reference an official source of TileMatrixSets so it is called "tileMatrixSetURI".

Here this is the TileMatrixSet definition, so it is to identify itself, not to reference something else.

joanma747 added a commit that referenced this issue Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants