Prevent errors in getRandomNumber call on PHP 8.1 #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is now mandatory to pass an integer to the function; otherwise an error is thrown. Currently if min is defined as null it will be passed as null, throwing an error. Max is allowed to be null, however.
|
Good catch! thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is now mandatory to pass an integer to the function; otherwise an error is thrown. This is due to changes in PHP 8 that removed using null as parameter in many php functions.
Currently if min is defined as null it will be passed as null, throwing an error.
Max is allowed to be null, however, since the Magento function will assign it a value if it's null.
I also assumed the original comparison of less than for max value was incorrect and changed it.