Skip to content

Commit

Permalink
♻️(models) set missing default values for xAPI activity types
Browse files Browse the repository at this point in the history
Some activity types declared with Pydantic were missing default values for types
field which forces library users to declare the type value when model is
instantiated. However, as these values are constants in xAPI semantics, we do
not want to request this from lib users.
  • Loading branch information
quitterie-lcs committed Apr 29, 2024
1 parent 65f334b commit 0a84249
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,9 @@ class WebpageActivityDefinition(BaseXapiActivityDefinition):
`https://w3id.org/xapi/acrossx/activities/webpage`.
"""

type: Literal["https://w3id.org/xapi/acrossx/activities/webpage"]
type: Literal["https://w3id.org/xapi/acrossx/activities/webpage"] = (
"https://w3id.org/xapi/acrossx/activities/webpage"
)


class WebpageActivity(BaseXapiActivity):
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ class FileActivityDefinition(BaseXapiActivityDefinition):
type (str): Consists of the value `http://activitystrea.ms/file`.
"""

type: Literal["http://activitystrea.ms/file"]
type: Literal["http://activitystrea.ms/file"] = "http://activitystrea.ms/file"


class FileActivity(BaseXapiActivity):
Expand Down
4 changes: 3 additions & 1 deletion src/ralph/models/xapi/concepts/activity_types/audio.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,9 @@ class AudioActivityDefinition(BaseXapiActivityDefinition):
`https://w3id.org/xapi/audio/activity-type/audio`.
"""

type: Literal["https://w3id.org/xapi/audio/activity-type/audio"]
type: Literal["https://w3id.org/xapi/audio/activity-type/audio"] = (
"https://w3id.org/xapi/audio/activity-type/audio"
)


class AudioActivity(BaseXapiActivity):
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,9 @@ class DocumentActivityDefinition(BaseXapiActivityDefinition):
`http://id.tincanapi.com/activitytype/document`.
"""

type: Literal["http://id.tincanapi.com/activitytype/document"]
type: Literal["http://id.tincanapi.com/activitytype/document"] = (
"http://id.tincanapi.com/activitytype/document"
)


class DocumentActivity(BaseXapiActivity):
Expand All @@ -45,7 +47,9 @@ class WebinarActivityDefinition(BaseXapiActivityDefinition):
`http://id.tincanapi.com/activitytype/webinar`.
"""

type: Literal["http://id.tincanapi.com/activitytype/webinar"]
type: Literal["http://id.tincanapi.com/activitytype/webinar"] = (
"http://id.tincanapi.com/activitytype/webinar"
)


class WebinarActivity(BaseXapiActivity):
Expand Down

0 comments on commit 0a84249

Please sign in to comment.