Skip to content

Commit

Permalink
📌(back) pin django-storages to version 1.14.3
Browse files Browse the repository at this point in the history
In version 1.14.4 there are at least two modifications made that lead to
a breaking change in Marsha.
The most annoying one is linked to this issue:
jschneier/django-storages#1430 and we have to
wait a newer version with a fix to have the previous behaviour. This fix
is related to a security issue in django. This security is fixed in
version 4.2.14 and we already use this version, so we are safe.
The second one is related to how the signature in computed when an url
is generated. Previously the signature was generated no matter if we
need it or not and then we choose to remove the signautre part using the
private method `_strip_signing_parameters`. This private does not exists
anymore, instead a new setting is used, we have to set the setting
`querystring_auth` to False to not compute the signature, it's real
improvement as it saves the cost of computing the signature.
  • Loading branch information
lunika committed Jul 30, 2024
1 parent 228d1ac commit 0ac4456
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 1 deletion.
10 changes: 10 additions & 0 deletions renovate.json
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,16 @@
"pytest"
],
"allowedVersions": "<8.0.0"
},
{
"enabled": false,
"groupName": "ignored python dependencies",
"matchManagers": [
"setup-cfg"
],
"matchPackageNames": [
"django-storages"
]
}
]
}
2 changes: 1 addition & 1 deletion src/backend/setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ install_requires =
django-parler==2.3
django-redis==5.4.0
django-safedelete==1.4.0
django-storages==1.14.4
django-storages==1.14.3
django-peertube-runner-connector==0.6.0
django-waffle==4.1.0
Django<5
Expand Down

0 comments on commit 0ac4456

Please sign in to comment.