Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

potential human error with respect to C-H bond for triple bonded carbon #81

Closed
davidlmobley opened this issue Nov 3, 2018 · 4 comments
Assignees

Comments

@davidlmobley
Copy link
Collaborator

Currently we have these bonds for C-H:

[#6X4:1]-[#1:2]                 340.0  1.090   parm99 aliphatic CH
[#6X3:1]-[#1:2]                 367.0  1.080   parm99 vinylic CH
[#6X2:1]-[#1:2]                 340.0  1.090   parm99 CZ-HZ alkyne #C-H

The comments in the FF and in @cbayly13 's conversion notes note that the triple bonded case (the last one) comes from the parm99 alkyne #C-H but parm99 has: CZ-HZ 400.0 1.056

Somehow this turned into:
[#6X2:1]-[#1:2] 340.0 1.090 parm99 CZ-HZ alkyne #C-H

I suspect this actually may be a copy and paste error, because the single bond is:
[#6X4:1]-[#1:2] 340.0 1.090 parm99 aliphatic CH

so the parameters are exactly the same.

I think we should be fixing the relevant line by switching it to
[#6X2:1]-[#1:2] 400.0 1.056 parm99 CZ-HZ alkyne #C-H

@cbayly13 input?

@cbayly13
Copy link
Collaborator

cbayly13 commented Nov 3, 2018

@davidlmobley I agree I probably made a cut and paste error, and that the values we should put in smirnoff99Frosst should be
[#6X2:1]-[#1:2] 400.0 1.056 parm99 CZ-HZ alkyne #C-H

@bannanc bannanc mentioned this issue Nov 6, 2018
@bannanc
Copy link
Collaborator

bannanc commented Nov 6, 2018

I can do this update tomorrow and adjust the README (see issue #82)

@bannanc bannanc self-assigned this Nov 6, 2018
@davidlmobley
Copy link
Collaborator Author

Great, thanks!

@bannanc
Copy link
Collaborator

bannanc commented Feb 21, 2019

This was fixed in PR #83 and is in the current release so I'm closing this issue.

@bannanc bannanc closed this as completed Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants