Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document why tolerance is removed from box edges #1159

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Conversation

mattwthompson
Copy link
Member

Description

Resolves #1106, in a sense

Checklist

  • Add tests
  • Lint
  • Update docstrings

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.38%. Comparing base (acbd6e4) to head (d837bfa).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1159   +/-   ##
=======================================
  Coverage   93.38%   93.38%           
=======================================
  Files          70       70           
  Lines        6028     6028           
=======================================
  Hits         5629     5629           
  Misses        399      399           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattwthompson mattwthompson marked this pull request as ready for review February 4, 2025 14:49
Copy link
Member

@j-wags j-wags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mattwthompson mattwthompson merged commit 523b20e into main Feb 5, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interchange subtracts tolerance when packing boxes, whereas Evaluator didn't.
2 participants