Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: keep reference to create react app #397

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Conversation

alexgarel
Copy link
Member

As their documentation might be useful

As their documentation might be useful
@alexgarel alexgarel requested a review from a team as a code owner February 12, 2024 09:50
Comment on lines +16 to +18
This project was initially setup using [Create React App](https://github.com/facebook/create-react-app), [the documentation](https://create-react-app.dev/) might be useful.


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Note that we should look to move to Vite soon, as create-react-app has been "deprecated" for quite some time (facebook/create-react-app#13072) and library documentation tend to not support the CRA use case

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, you know ;-)

@alexgarel alexgarel merged commit 92ff90a into main Feb 14, 2024
8 of 9 checks passed
@alexgarel alexgarel deleted the doc-create-react-app branch February 14, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants