fix(test): remove determinism of parent order in tests #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perierc
changed the title
|
Another short term fix would be to get rid of the two parents in the test file. Not sure what is preferable. |
|
Instead of updating the tests to get the tests passing, I updated the code here #337 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Currently, parent order is not deterministic when parsing and unparsing a taxonomy. Thus, the tests sometimes fail or pass (see https://github.com/openfoodfacts/taxonomy-editor/actions/runs/7555310972 and https://github.com/openfoodfacts/taxonomy-editor/actions/runs/7555383123/job/20570246361 that come from exactly the same code)
This is a short term fix: the goal is to add parent order determinism in a future PR (as well as good comment locality)