Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(taxonomy-editor-frontend): redirect user to node editor when clicking from nodes page #284

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

Piv94165
Copy link
Contributor

@Piv94165 Piv94165 commented Nov 9, 2023

What

User can not choose a node to edit from Nodes page.
To do that, has to go to Search page and click on it.

Screenshot

Go to https://ui.taxonomy.openfoodfacts.net/states/editstostates/entry
And try to click on an edit button (nothing happens)

Fixes bug(s)

Now, on Nodes page, user can click on an edit button to go to node editor.

Part of

taxonomy-editor-frontend

@Piv94165 Piv94165 requested a review from a team as a code owner November 9, 2023 16:10
@Piv94165
Copy link
Contributor Author

Piv94165 commented Nov 9, 2023

This change fixes the bug.
But it could be the opportunity to refactor a bit, since code is duplicated (search pages and nodes pages could use the same component)

Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge. Refactor is needed indeed, but I will open a specific issue.

@alexgarel alexgarel merged commit 089df89 into main Nov 10, 2023
9 checks passed
@alexgarel alexgarel deleted the fix/edit-taxonomy-from-editor branch November 10, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

2 participants