Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #122
Changes to the
--map
option of show data.No longer show data when a single asset is returned
Demand each word be the name of an assetAllow assets to end with
-bmc
Remove splitting on
=
CHANGE TO REQUIREMENTS
Now have all assets' names that occur anywhere as substrings be returned
This should hopefully only run at around 5n operations, where n is the number of assets in the systemThinking about it this is fully incorrect as checking a length m string includes a substring takes m operations so this is around nm +4n operations or O(nm)
It is also worth noting here how this solution deals with the edge case in which there are asset names that are substrings of other asset names in the system. In the case that the longer asset is specified in the map, they're both returned.
Timing looks like so
where no command is: