Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group switch on list #106

Merged
merged 7 commits into from
Mar 22, 2019
Merged

Group switch on list #106

merged 7 commits into from
Mar 22, 2019

Conversation

atoghill
Copy link
Contributor

This PR addresses the first half of #93.

There is now a --group option on the list command that allows the user to list assets within the specified group(s).

@atoghill atoghill requested a review from DavidMarchant March 22, 2019 11:12
@DavidMarchant
Copy link
Contributor

LGTM! thanks
I think having List inherit from MultiNodeCommand isn't the cleanest thing ever (as it isn't reaaally a command which you specify multiple nodes for) but I can absolutely see why you've done it & I can't really think of a nicer way to split up the code base at present so I'll merge it through

@DavidMarchant DavidMarchant merged commit 13cd0e8 into develop Mar 22, 2019
@DavidMarchant DavidMarchant deleted the feature/group-switch-on-list branch March 22, 2019 12:25
@atoghill
Copy link
Contributor Author

Yeah I wasn't the biggest fan of it but when I initially extracted the main method used to find the assets within a group I kept finding dependencies on other methods. So I opted for the safest change and seeing as it isn't a user facing problem didn't think too much of it 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants