Map metadata #104
Merged
Map metadata #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
March 20, 2019 12:10
This is a test of tty-prompt that will be used to ask the user if they wish to add map metadata or not when running `modify map` on an asset. For now this will use no as the default so the user can simply press enter to skip adding metadata for an asset's map.
This will appear as `map_dimensions` and `map_pattern` under the `mutable` header.
The `action` method felt cluttered with all the prompts housed within it. So I have moved these to the new `get_map_metadata_from_user` method that is called if the user selects yes on the first prompt.
|
LGTM! Thanks for this, especially the fancy gif |
|
O M G FANCY GIF! 🤯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced in this PR is the ability to specify new map metadata using the
modify mapcommand. As shown in the attached gif users are first prompted as to whether or not they wish to add metadata to the map, this defaults to no and pressing enter skips straight to the editor like it would previously.However if the user enters some variation of yes then they will be prompted to enter values for both the map dimensions and pattern, as described in #102.
Resolves #102 when merged.