Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Erfs data improved #189

Merged
merged 5 commits into from
May 7, 2021
Merged

Erfs data improved #189

merged 5 commits into from
May 7, 2021

Conversation

magemax
Copy link
Contributor

@magemax magemax commented Oct 21, 2020

Thanks for contributing to OpenFisca-France-Data! Remove this line, as well as any other in the following that don't fit your contribution :)

Technical changes

  • Openfisca-france-data now handles more formats of the ERFS-FPR (the files produced do not always have the exact same columns / column names)

@magemax magemax requested a review from sandcha October 21, 2020 15:29
@benoit-cty
Copy link
Contributor

Bonjour @benjello ,
Qu'est-ce qu'il faudrait que l'on fasse pour que cette PR soit acceptée ?
Ou faut-il la rejeter et modifier nos procédures ?

@benoit-cty benoit-cty requested a review from benjello May 7, 2021 09:38
@benoit-cty benoit-cty self-assigned this May 7, 2021
@benjello
Copy link
Member

benjello commented May 7, 2021

@benoit-cty . Cela m'a l'air pas mal du tout.
Cela vaudrait le coup d'avoir l'avis de @FrancoisTeyssier pour voir si ce n'est pas une façon élégante de régler son problème d'absence de noiper.

@benoit-cty ok pour lancer un rebase et merger cette PR.

@benoit-cty benoit-cty force-pushed the erfs-data-improved branch from f690bc4 to 3b7241c Compare May 7, 2021 12:13
@benoit-cty benoit-cty merged commit fb651cb into master May 7, 2021
@benoit-cty benoit-cty deleted the erfs-data-improved branch May 7, 2021 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants