Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update numpy to >=1.11,<1.16 #758

Merged
merged 2 commits into from
Nov 10, 2018
Merged

Update numpy to >=1.11,<1.16 #758

merged 2 commits into from
Nov 10, 2018

Conversation

Br3nda
Copy link
Contributor

@Br3nda Br3nda commented Nov 6, 2018

Technical changes

  • Updates the requirements on numpy to permit the latest version.

@fpagnoux
Copy link
Member

fpagnoux commented Nov 6, 2018 •
edited
Loading

There are usually breaking changes coming with new versions of Numpy. Did someone check what they are?
@Morendil, did you try to run France's test with Numpy 1.15?

@Morendil
Copy link
Contributor

Morendil commented Nov 6, 2018

Nope, I only eyeballed the release notes; I'll run them right now.

@Morendil
Copy link
Contributor

Morendil commented Nov 6, 2018

We're green :)

@fpagnoux
Copy link
Member

fpagnoux commented Nov 6, 2018

Great. Looking at the Numpy changelog, I don't see anything that looks like a breaking change in the OpenFisca context.

@bonjourmauko
Copy link
Member

This requires a version bump though.

@bonjourmauko bonjourmauko changed the title Update numpy requirement from <1.15,>=1.11 to >=1.11,<1.16 Update numpy to >=1.11,<1.16 Nov 9, 2018
dependabot-support and others added 2 commits November 10, 2018 00:59
@dependabot-support
Update numpy requirement from <1.15,>=1.11 to >=1.11,<1.16
b2a82be 
Updates the requirements on [numpy](http://www.numpy.org) to permit the latest version.

Signed-off-by: dependabot[bot] <support@dependabot.com>
@Br3nda
Version bump and change log
e571541
@bonjourmauko bonjourmauko force-pushed the dependabot/pip/numpy-gte-1.11-and-lt-1.16 branch from b8d5c23 to e571541 Compare November 10, 2018 00:21
@bonjourmauko bonjourmauko merged commit 7914f98 into openfisca:master Nov 10, 2018
@bonjourmauko bonjourmauko added the kind:refactor Refactoring and code cleanup label Nov 13, 2018
@Br3nda Br3nda deleted the dependabot/pip/numpy-gte-1.11-and-lt-1.16 branch January 15, 2019 18:44
This was referenced Apr 28, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpagnoux fpagnoux fpagnoux approved these changes

@Morendil Morendil Morendil approved these changes

Assignees
No one assigned
Labels
kind:refactor Refactoring and code cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Br3nda @fpagnoux @Morendil @bonjourmauko @dependabot-support