Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle parallel testing #516

Merged
merged 5 commits into from
May 31, 2017
Merged

Handle parallel testing #516

merged 5 commits into from
May 31, 2017

Conversation

fpagnoux
Copy link
Member

@fpagnoux fpagnoux commented May 23, 2017

Connected to openfisca/openfisca-france#734

New features

  • Use nose in the openfisca-run-test script
    • This avoids boilerplate code on country packages, and makes parallelism easier to set on Circle CI.

Copy link
Member

@cbenz cbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still not enough convinced about why there is a need to implement this mechanism (node-index and nb-nodes) into the script, and about why there is a --nose option.

Is it OK to tie the script to the CI needs?

I'm not criticizing the implementation; I just don't want to approve a code for which I don't understand the rationale :-)

@fpagnoux
Copy link
Member Author

Good point 👍 .
It's indeed better to keep the parallelism business out of the core if we can.
I found an alternative implementation.

I still need the --nose option though. This options allows me to run OpenFisca YAML tests cases with nose (CI-friendly output, no failfast) without a boilerplate test_yaml.py. This has two advantages:

@fpagnoux fpagnoux requested a review from cbenz May 24, 2017 17:13
Copy link
Member

@cbenz cbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, so I understand now!

The --nose option runs the specified YAML tests using nose as a runner.

But couldn't we keep this option as the default and only one? When is it useful not to use this option?

@fpagnoux
Copy link
Member Author

But couldn't we keep this option as the default and only one? When is it useful not to use this option?

Good question. The only drawback I see is that if running with nose is the only option, then
- Either nosetests becomes a dependency of openfisca-core
- Or we keep it as a test dependency, but anyone who wants to run YAML tests must pip install openfisca_xxx[test]

I guess the second option is ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants