Skip deploy workflow when PyPI token is not defined in GitHub secrets

[Ndpnt]

• Technical improvement
• Impacted areas: CI workflows
• Details:
  • Skip deploy workflow when PyPI token is not defined in GitHub secrets
  • Rename the GitHub secret PYPI_TOKEN_OPENFISCA_BOT used in deploy workflow to PYPI_TOKEN
  • Ensure lint scripts work properly without reachable tags
  • Update deprecated syntax in GitHub Action workflow

[MattiSG]

Excellent work!
However, in my testing, git describe --always falls back to HEAD in case there are no tags, meaning that in such a case we will never lint any file. I understand this is better than failing, but I believe we can come up with a better alternative in case there are no tags, such as using the GitHub-provided PR target, or maybe git rev-list --max-parents=0 HEAD to get the root commit and thus lint all files.

[MattiSG]

If we go multiline, let's do it all the way 😉

Suggested change

	if "${GITHUB_WORKSPACE}/.github/has-functional-changes.sh" ; then
	echo "status=success" >> $GITHUB_OUTPUT
	if "${GITHUB_WORKSPACE}/.github/has-functional-changes.sh"
	then echo "status=success" >> $GITHUB_OUTPUT

[MattiSG]

The comment you made in the commit to explain the implementation is really good, but it would be useful to also have it as a comment in the code to save some future smartass 😉

[MattiSG]

We will need @sandcha to create a new PyPI token too, to set the new PYPI_TOKEN variable 😅

[MattiSG]

Beautiful 🤩
Let's merge without PYPI_TOKEN defined to confirm that deployment is cleanly skipped, and then define it and re-run the job to confirm that deployment is activated 🙂