Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the estimation logic for hybrid key switching #883

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Fixed the estimation logic for hybrid key switching #883

merged 2 commits into from
Oct 23, 2024

Conversation

yspolyakov
Copy link
Contributor

@yspolyakov yspolyakov commented Oct 22, 2024 •
edited
Loading

  1. Incremented the estimated modulus for BGV and CKKS by 1 to account for RNS moduli above the desired bit width
  2. Incremented the maximum digit size in hybrid key switching for BGV and CKKS by 1 to account for RNS moduli above the desired bit width

@yspolyakov yspolyakov added the bug Something isn't working label Oct 22, 2024
@yspolyakov yspolyakov added this to the Release 1.2.2 milestone Oct 22, 2024
@yspolyakov yspolyakov linked an issue Oct 22, 2024 that may be closed by this pull request
Fix the logic for estimating the digit size in hybrid key switching #879
Closed
andreea-alexandru
andreea-alexandru approved these changes Oct 23, 2024
View reviewed changes
Copy link
Collaborator

@andreea-alexandru andreea-alexandru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic looks good.

dsuponitskiy
dsuponitskiy approved these changes Oct 23, 2024
View reviewed changes
Copy link
Collaborator

@dsuponitskiy dsuponitskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@dsuponitskiy dsuponitskiy merged commit d006fb3 into dev Oct 23, 2024
26 checks passed
@dsuponitskiy dsuponitskiy deleted the polyakov-879 branch October 31, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsuponitskiy dsuponitskiy dsuponitskiy approved these changes

@andreea-alexandru andreea-alexandru andreea-alexandru approved these changes

Assignees

@dsuponitskiy dsuponitskiy

Labels
bug Something isn't working
Projects
None yet
Milestone
Release 1.2.2
Development

Successfully merging this pull request may close these issues.

Fix the logic for estimating the digit size in hybrid key switching
3 participants
@yspolyakov @dsuponitskiy @andreea-alexandru