-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for specifying consistency parameter #70
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #70 +/- ##
==========================================
+ Coverage 30.96% 31.15% +0.19%
==========================================
Files 119 122 +3
Lines 6030 6083 +53
Branches 784 785 +1
==========================================
+ Hits 1867 1895 +28
- Misses 4007 4030 +23
- Partials 156 158 +2 ☔ View full report in Codecov by Sentry. |
This reverts commit e7bf34e.
82a54c7
to
fe663b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, I'd also suggest @rhamzeh takes a look as he's more familiar with the SDK/the issue with the unspecified enum
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't approve my own PR, but ✅ from me. Thanks @jimmyjames!
## Release v0.5.0 - feat: support consistency parameter (#70)
Adds support for specifying the consistency parameter.
Description
Supports the ability to specify the consistency parameter for those endpoints that accept it (read, check, list users, list objects, and expand).
Note that a change to
JsonStringEnumMemberConverter
is also required to support the new enumUNSPECIFIED
along with itsEnumMember
value (alsoUNSPECIFIED
). Otherwise, there are errors when attempting to add the same key twice to the dictionary.In addition to the included unit tests, manual testing was also done using the example application to verify that the enum changes work as expected, and that the consistency parameter is being sent.
References
Review Checklist
main