Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix node20 template name in package.json #313

Closed
1 of 2 tasks
juliancasaburi opened this issue Nov 11, 2024 · 0 comments
Closed
1 of 2 tasks

Fix node20 template name in package.json #313

juliancasaburi opened this issue Nov 11, 2024 · 0 comments

Comments

@juliancasaburi
Copy link

Expected Behaviour

The template for Node.js 20 should be named openfaas-node20

Current Behaviour

The template is named openfaas-node18 in package.json, which can cause confusion about the Node.js version it supports.

Are you a GitHub Sponsor (Yes/No?)

Check at: https://github.com/sponsors/openfaas

  • Yes
  • No

List All Possible Solutions and Workarounds

Rename openfaas-node18 to openfaas-node20

Which Solution Do You Recommend?

Rename openfaas-node18 to openfaas-node20

Steps to Reproduce (for bugs)

  1. Check the available OpenFaaS templates for Node.js versions.
  2. Open the package.json file in the node20 template folder.
  3. Observe that the value of name is openfaas-node18.

Context

Changing this would make the template name compliant and aligned with the Node version it makes use.

Your Environment

Not relevant

juliancasaburi added a commit to juliancasaburi/templates that referenced this issue Nov 11, 2024
juliancasaburi added a commit to juliancasaburi/templates that referenced this issue Nov 11, 2024
Signed-off-by: Julian Casaburi <juliancasaburi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant