disable istio injection for nats and alertmanager in yaml files

[GuillaumeMorini]

Description

I have disabled istio injection in the yaml files in the same way it was done in the helm charts

Motivation and Context

To solve issue #369

How Has This Been Tested?

Tested on Kubernetes 1.11.7

Types of changes

• [ x] Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• [x ] My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• [ x] I've read the CONTRIBUTION guide
• I have signed-off my commits with git commit -s
• I have added tests to cover my changes.
• [x ] All new and existing tests passed.

[derek]

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide.
Tip: if you only have one commit so far then run: git commit --amend --sign-off and then git push --force.

[alexellis]

Hi @GuillaumeMorini thanks for your PR.

You will need to sign off every commit and remove your merge commits (which are unnecessary)

I'd suggest a simple git reset followed by git stash then rebase with origin/master and pop the changes off for a new commit that is signed-off.

Alex

[alexellis]

@GuillaumeMorini I noticed you work at Docker. If you're using OpenFaaS with Docker EE, please install with helm and not with plain YAML.

The chart enables basic-auth and has more configuration options, you can also use the chart to generate YAML if you prefer to install OpenFaaS without tiller and only using kubectl.

[GuillaumeMorini]

Thanks Alex

…

Le 6 avr. 2019 à 20:31, Alex Ellis ***@***.***> a écrit : @GuillaumeMorini I noticed you work at Docker. If you're using OpenFaaS with Docker EE, please install with helm and not with plain YAML. The chart enables basic-auth and has more configuration options, you can also use the chart to generate YAML if you prefer to install OpenFaaS without tiller and only using kubectl. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.