Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OPENEUROPA-1371: Allow users to define a custom Task Runner configuration in their home directory. #63

Merged
merged 10 commits into from
Feb 8, 2019
Merged

OPENEUROPA-1371: Allow users to define a custom Task Runner configuration in their home directory. #63

merged 10 commits into from
Feb 8, 2019

Conversation

drupol
Copy link
Contributor

@drupol drupol commented Jul 3, 2018

Fix #62

@drupol drupol force-pushed the 62-custom-user-configuration branch 7 times, most recently from cac4b8d to 93b2fd5 Compare July 3, 2018 14:48
@drupol drupol force-pushed the 62-custom-user-configuration branch from 93b2fd5 to 3252c5c Compare July 19, 2018 08:59
@drupol drupol mentioned this pull request Jul 19, 2018
Merged
@drupol drupol force-pushed the 62-custom-user-configuration branch from 683d6ee to 42fdc9f Compare November 26, 2018 09:44
@drupol drupol force-pushed the 62-custom-user-configuration branch from 40bc01b to 08a1d9b Compare January 15, 2019 12:33
voidtek
voidtek requested changes Jan 23, 2019
View reviewed changes
Copy link
Member

@voidtek voidtek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mandatory change

  • The PR change the permission file of tests/sandbox/.gitkeep 100644 → 100755.

Optional change

  • Add tests to check the priority order of variables

tests/CommandsTest.php Outdated Show resolved Hide resolved
tests/CommandsTest.php Show resolved Hide resolved
src/TaskRunner.php Show resolved Hide resolved
@drupol drupol force-pushed the 62-custom-user-configuration branch 4 times, most recently from 46b447d to 414102d Compare January 29, 2019 08:16
@drupol drupol changed the title Issue #62: Allow users to define a custom Task Runner configuration in their home directory. OPENEUROPA-1371: Allow users to define a custom Task Runner configuration in their home directory. Jan 30, 2019
pfrenssen
pfrenssen requested changes Jan 31, 2019
View reviewed changes
src/TaskRunner.php Outdated Show resolved Hide resolved
src/TaskRunner.php Outdated Show resolved Hide resolved
@drupol drupol force-pushed the 62-custom-user-configuration branch from f6f0b60 to 09065ce Compare February 5, 2019 13:40
@drupol drupol force-pushed the 62-custom-user-configuration branch from 09065ce to 3a90ac9 Compare February 5, 2019 13:43
@drupol drupol force-pushed the 62-custom-user-configuration branch from 3a90ac9 to 4985d98 Compare February 5, 2019 13:53
@drupol drupol merged commit 06bd78b into master Feb 8, 2019
@drupol drupol deleted the 62-custom-user-configuration branch February 8, 2019 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pfrenssen pfrenssen pfrenssen approved these changes

@voidtek voidtek voidtek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@drupol @voidtek @pfrenssen @sergepavle