EWPP-1846: Upgrade task-runner to PHP 8. #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yenyasinn
force-pushed
the
EWPP-1846
branch
4 times, most recently
from
aded244 to
f329617
Compare
hernani
force-pushed
the
EWPP-1846
branch
2 times, most recently
from
a932bac to
c9a5c09
Compare
yenyasinn
commented
Jan 7, 2022
tests/AbstractTaskTest.php
Outdated
| @@ -29,7 +29,7 @@ abstract class AbstractTaskTest extends AbstractTest implements ContainerAwareIn | |||
| /** | |||
| * Setup hook. | |||
| */ | |||
| public function setup() | |||
| public function setUp(): void | |||
There was a problem hiding this comment.
Suggested change
| public function setUp(): void | |
| protected function setUp(): void |
| image: fpfis/httpd-php-dev:7.3 | ||
| image: fpfis/httpd-php-dev:8.0 |
There was a problem hiding this comment.
Why are we using the fpfis/httpd-php image? Task Runner is only dealing with PHP on CLI level, it doesn't need a webserver (Apache, Nginx, etc). Using an image such as php:8.0-cli would allow us to be more generic and not coupled to EC. Remember, Task Runner is supposed to be an opensource tool.
Also, this would allow to test also with PHP 8.1 as FPFIS image for 8.1 is not yet out.
hernani
force-pushed
the
EWPP-1846
branch
2 times, most recently
from
24c14bd to
809a93b
Compare
hernani
previously approved these changes
Jan 17, 2022
claudiu-cristea
previously approved these changes
Jan 17, 2022
brummbar
previously approved these changes
Jan 17, 2022
hernani
dismissed stale reviews from brummbar, claudiu-cristea, and themself
The base branch was changed.
hernani
approved these changes
Jan 17, 2022
brummbar
approved these changes
Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.