MULTISITE-23486: Allow dynamic commands to override all code provided commands #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d may be overriden.
…lative namespace.
… than re-reading them from config to overcome issues with aliases.
…if there are dynamic commands.
|
This is looking good, just a few small nitpicks. I spent a lot of time trying to understand the working of the library, so I went ahead and added documentation for the code that is touched by this PR. This will hopefully make it easier for others to understand the purpose of the code, and save them some time. |
pfrenssen
requested changes
May 11, 2020
claudiu-cristea
force-pushed
the
MULTISITE-23486
branch
from
1cf2280 to
cc90d4a
Compare
|
I've fixed the remarks. |
pfrenssen
approved these changes
May 18, 2020
idimopoulos
approved these changes
May 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MULTISITE-23486
Description
Right now, a dynamic command can override a default commands, such as
drupal:site-installorrelease:create-archive. But it cannot override commands provided by 3rd party, such asec-europa/toolkit. The reason is that such commands are discovered after discovering dynamic commands, in\Robo\Runner::run().This PR swaps the order by discovering and registering the 3rd party commands before registering dynamic commands, so that a command provided in
runner.ymlwill override an class annotated command.Change log
Commands