Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure consolidation/annotated-command has the right version #95

Closed
drupol opened this issue Mar 11, 2019 · 0 comments
Closed

Ensure consolidation/annotated-command has the right version #95

drupol opened this issue Mar 11, 2019 · 0 comments

Comments

@drupol
Copy link
Contributor

drupol commented Mar 11, 2019

During the development of Atomium, we noticed that some builds were failing on Drone while using composer install --prefer-lowest using Drush 8.2.0.

See: https://drone.fpfis.eu/ec-europa/atomium/496/22

It seems that when downgrading consolidation/robo from 1.4.6 to 1.3.0, the dependency consolidation/annotated-command gets downgraded from 2.12.0 to 2.9.1.

Unfortunately, the version 2.9.1 doesn't contain the class Consolidation\AnnotatedCommand\Parser\CommandInfo::getInjectedClasses() required by Drush by 8.2.0 during Drupal install (See diff from 8.1.18 to 8.2.0)

There are 2 ways to fix this.

Either we increase the consolidation/robo version from ^1.3.0 to a higher version (^1.4.0 probably)
Either we add a dependency to consolidation/annotated-command and set the proper version.

I prefer by far the first proposition.

@drupol drupol changed the title Force consolidation/annotated-command to use higher version Ensure consolidation/annotated-command has the right version Mar 11, 2019
ademarco added a commit that referenced this issue Mar 12, 2019
Issue #95: Upgrade minimum version of Robo so it works with Drush 8.2.0 properly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant